Skip to content

GA-163 | test_multidigraph #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Aug 28, 2024

Branched off of #42

@aMahanna aMahanna changed the title WIP: GA-163 | test_multidigraph GA-163 | test_multidigraph Aug 28, 2024
@aMahanna aMahanna requested a review from hkernbach August 29, 2024 17:52
Copy link
Member

@hkernbach hkernbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left some minor comments.

@aMahanna aMahanna merged commit ae63c72 into GA-163-multigraph Aug 30, 2024
6 checks passed
@aMahanna aMahanna deleted the GA-163-multidigraph branch August 30, 2024 12:10
aMahanna added a commit that referenced this pull request Aug 30, 2024
* GA-163 | initial commit

will fail

* unlock adbnx

* fix: `incoming_graph_data`

* fix: incoming_graph_data

* fix: off-by-one IDs

* checkpoint

* checkpoint: `BaseGraphTester` is passing

* checkpoint: BaseGraphAttrTester

* cleanup: `aql_fetch_data`, `aql_fetch_data_edge`

* use pytest skip for failing tests

* checkpoint: optimize `__iter__`

* checkpoint: run `test_graph`

* add comment

* checkpoint

* attempt: slleep

* fix: lint

* cleanup: getitem

* cleanup: copy

* attempt: shorten sleep

* fix: `__set_adj_elements`

* fix: mypy

* attempt: decrease sleep

* GA-163 | `test_digraph`

* checkpoint

lots of failures...

* fix: set `self.Graph`

* add type ignore

* fix: graph name

* fix: graph name

* adjust assertions to exclude _rev, set `use_experimental_views`

* Revert "adjust assertions to exclude _rev, set `use_experimental_views`"

This reverts commit b805419.

* fix: `_rev`, `use_experimental_views`

* set `use_experimental_views`

* fix: lint

* new: `nbunch_iter` override

* set experimental views to false

* set experimental views to false

* cleanup

* GA-163 | `test_multigraph` checkpoint

* fix lint

* fix: `function.py`

* cleanup: `graph`, `digraph`

* fix: `test_data_input`

* attempt: wait for CircleCI

* fix: nx graph

* remove sleep

* new: `override` suffix

* add override

* enable more tests

* fix: lint

* checkpoint

tests are still failing

* checkpoint: 2 remaining test failures

* fix: lint

* checkpoint: one last failing test

tried to debug this. no answer yet..

* remove: `logger_debug`, fix lint

* lint

* fix: `test_multigraph`

* cleanup, add missing test

* new: `test_non_multigraph_input_a`

* add comments

* GA-163 | `test_multidigraph` (#45)

* checkpoint: `test_multidigraph`

* checkpoint: 1 failing test for each file: `test_digraph`, `test_multigraph`, `test_multidigraph`

* fix: `test_to_undirected_reciprocal`

* remove unused block

* fix: `write_async` False

---------

Co-authored-by: hkernbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants