Skip to content
This repository was archived by the owner on Dec 3, 2020. It is now read-only.

Fix file path comparison #23

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

gjsduarte
Copy link
Contributor

@gjsduarte gjsduarte commented Nov 6, 2018

Even if the forward slashes wouldn’t be supported, we are only using them to compare the paths, so they must be sanitized on both sides of the comparison.

Copy link
Contributor

@rtfpessoa rtfpessoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method has a really bad name 👎 but since it was already there I will let it pass. 😢

@rtfpessoa rtfpessoa merged commit ce42b87 into master Nov 7, 2018
@rtfpessoa rtfpessoa deleted the bugfix/FT-6145-coverage-report-generation branch November 7, 2018 17:07
@rtfpessoa
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants