Correct case of "Type" in librarymanager links in examples #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arduino IDE has a feature where opening a link of the form `http://librarymanager[/<type>[/<topic>][#<search keywords>]` opens Library Manager with the specified filters and keywords prefilled. Support for specifying the "Type" filter setting was claimed during the implementation of the feature in Arduino IDE 1.x, but that never actually worked. The text in this path was simply ignored by the IDE (a fact that would not be obvious from the links used by this library, since the "All" type filter setting is the default anyway). During the reimplementation of the feature in Arduino IDE 2.x, support for specifying the Type filter setting was actually implemented correctly. Instead of ignoring this path component of the URL, the IDE requires it to match to a valid "Type" filter value. If there is no match, opening the link has no effect. This match is case sensitive. The previous URLs used the type value "all", but there is no "all" value in the "Type" filter. Instead, there is an "All" value, and that exact case must be used in order for the link to function in Arduino IDE 2.x.
per1234
added
type: imperfection
|
Memory usage change @ 2fce77f
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arduino IDE has a feature where opening a link of the form:
opens Library Manager with the specified filters and keywords prefilled.
Support for specifying the "Type" filter setting was claimed during the implementation of the feature in Arduino IDE 1.x (arduino/Arduino@b99ab40), but that never actually worked. The text in this path was simply ignored by the IDE (a fact that would not be obvious from the links used by this library, since the "All" type filter setting is the default anyway).
During the reimplementation of the feature in Arduino IDE 2.x (arduino/arduino-ide#1481), support for specifying the "Type" filter setting was actually implemented correctly. Instead of ignoring this path component of the URL, the IDE requires it to match to a valid "Type" filter value. If there is no match, opening the link has no effect. This match is case sensitive.
The previous URLs used the type value "all", but there is no "all" value in the "Type" filter. Instead, there is an "All" value, and that exact case must be used in order for the link to function in Arduino IDE 2.x.