Change EthernetClient to use IANA recommended ephemeral port range #2345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is essentially a duplicate of #2249, but since this request has some more reasoning and uses a more standard port number, I'll close that one in favour of this one. |
matthijskooijman
added
Library: Ethernet
cmaglie
added a commit
that referenced
this pull request
Oct 8, 2014
Change EthernetClient to use IANA recommended ephemeral port range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain ISPs block certain ports and this can cause connect failures for Ethernet clients. By changing the port range used in EthernetClient.cpp from 1024-65535 to the IANA-recommended "ephemeral port" range of 49152-65535, these failures should be minimized as ISPs should be less likely to block ports in this range. Note that recent versions of Windows and FreeBSD use the IANA-recommended range. See http://en.wikipedia.org/wiki/Ephemeral_port
In my case, failures occurred on port 1080, which is blocked by Comcast (one of the largest ISPs in the USA), see http://customer.comcast.com/help-and-support/internet/list-of-blocked-ports/