Add USB Serial Port Callbacks #2469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
NicoHood
pushed a commit
to NicoHood/HID
that referenced
this pull request
Dec 9, 2014
arduino/Arduino#2469 Weak implementation sounds usefull but takes 6 more bytes of flash/ function (12). Even more, if we would also pass the line states but the user can read this with Serial.dtr() for example. arduino/Arduino#1179 Should we inline the Serial.dtr() functuions etc? But then we need to move the line info to the header as well, also the definition. These optional functions only take flash if they are used. Virtual isnt used, because this would take more flash for no reason. Syntax like this: https://www.pjrc.com/teensy/td_serial.html
|
A similar implementation can be found here: |
|
I would advise caution when considering interrupt callbacks. Such callbacks are seductive, since they promise very immediate response, and because they're so easy to implement. But exposing end users to interrupt context should be avoided, if possible. Interrupt context is a nightmare of thorny programming, requiring very careful design to properly share any data with other parts of the code that aren't interrupt based. Even experts often get it wrong. Bugs tend to be subtle and almost impossible to diagnose. A good portion of the Arduino API also isn't safe to use from interrupt context. |
cmaglie
added
feature request
facchinm
added
the
USB: CDC serial
|
This may be closed with the new API now. |
|
Fixed with #3343. |
obra
pushed a commit
to keyboardio/Kaleidoscope
that referenced
this pull request
Dec 14, 2023
arduino/Arduino#2469 Weak implementation sounds usefull but takes 6 more bytes of flash/ function (12). Even more, if we would also pass the line states but the user can read this with Serial.dtr() for example. arduino/Arduino#1179 Should we inline the Serial.dtr() functuions etc? But then we need to move the line info to the header as well, also the definition. These optional functions only take flash if they are used. Virtual isnt used, because this would take more flash for no reason. Syntax like this: https://www.pjrc.com/teensy/td_serial.html
obra
pushed a commit
to keyboardio/Kaleidoscope
that referenced
this pull request
Dec 14, 2023
arduino/Arduino#2469 Weak implementation sounds usefull but takes 6 more bytes of flash/ function (12). Even more, if we would also pass the line states but the user can read this with Serial.dtr() for example. arduino/Arduino#1179 Should we inline the Serial.dtr() functuions etc? But then we need to move the line info to the header as well, also the definition. These optional functions only take flash if they are used. Virtual isnt used, because this would take more flash for no reason. Syntax like this: https://www.pjrc.com/teensy/td_serial.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These edits allow the functions lineCodingEvent and lineStateEvent to be used in sketches to know when the virtual serial port's control lines or baud rate changes.
They are needed for creating sketches that act as a USB->Serial Port interface or interfacing with software that uses these signals as controls.
They were originally authored by Peter Van Hoyweghen http://petervanhoyweghen.wordpress.com/2012/11/08/using-the-leonardo-as-usb-to-serial-converter/