CLI: Add --version to CLI option #7549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added to get the Arduino IDE version from the command line It will allow to check easily if the new Arduino is already installed. This feature makes it easier to build external systems linked to specific versions of Arduino. 1. I added `--version` action, which shows version name and exit 1. Currently, VERSION_NAME_LONG (like `1.8.5`, `1.9.0-beta`, `1.8.6 Hourly Build XXX`, etc...) is used. Because I want to know its version number and stable/beta/hourly. 2. Finish with `0`. Because it is `SUCCESSFLLY FINISHED`. 2. Updated man page.
matthijskooijman
requested changes
May 2, 2018
| @@ -84,6 +85,10 @@ public void parseArgumentsPhase1() { | |||
| } | |||
| libraryToInstall = args[i]; | |||
| } | |||
| if (a == ACTION.VERSION) { | |||
| BaseNoGui.showMessage("Arduino", BaseNoGui.VERSION_NAME_LONG); | |||
| System.exit(0); | |||
There was a problem hiding this comment.
I'm not sure I like this exit here, this bypasses any cleanup that would normally (perhaps) run after this function returns. Also, this function is expected to parse arguments only, not act on them. Also, passing --version --verify now just acts on --version, instead of showing an error that only one of them can be passed.
Better would seem to set action here, and act on it elsewhere.
There was a problem hiding this comment.
You're right!
Thank you for your comment.
Move print action to probably suitable place. This commit will fix the behavior of multiple actions about --version.
|
@matthijskooijman Is this better with the changes? |
facchinm
approved these changes
May 21, 2018
|
Thank you, reviewers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added to get the Arduino IDE version from the command line
It will allow to check easily if the new Arduino is already installed.
This feature makes it easier to build external systems linked to specific versions of Arduino.
--versionaction, which shows version name and exit1.8.5,1.9.0-beta,1.8.6 Hourly Build XXX, etc...) is used. Because I want to know its version number and stable/beta/hourly.0. Because it isSUCCESSFLLY FINISHED.