Annotate custom menu to avoid name clashing #8880
Conversation
facchinm
added
the
Component: IDE user interface
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8880-BUILD-854-linux32.tar.xz ℹ️ The |
|
@facchinm Hi just replace the java file in my Arduino path? |
|
You can grab the right package for your OS, unzip it and run arduino executable from there. |
|
@facchinm using test build 854, I can no longer reproduce the problem with the "Upload Speed" menu of the ESP32 and ESP8266 cores. However, I can still reproduce the original issue with the "Processor" menu of Arduino AVR Boards' Arduino Mega and Mega 2560 and avr_boot's ATmega328/P boards: |
|
@per1234 thanks a lot for testing, I'm taking a look immediately |
This stuff is truly madness, should be refactored from the ground up by a Java expert
|
I pushed a new commit, tested against the original bug and seems to fix it. However that piece of code is really a nightmare and should be refactored by someone who knows Swing sooner or later. |
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8880-BUILD-857-linux32.tar.xz ℹ️ The |
|
Hi |
|
@facchinm still the same problem with the "Processor" menu of Arduino AVR Boards' "Arduino Mega and Mega 2560" and avr_boot's "ATmega328/P" boards for me using build 857. I notice that if the "Arduino Mega and Mega 2560" board is selected when I start the Arduino IDE and I then select Tools > Board > ATmega328/P, the problem does not occur. I need to select Tools > Board > Arduino Mega and Mega 2560 (even if it was already selected) before selecting Tools > Board > ATmega328/P to reproduce the bug. |
|
Maybe it is a good Idea to do the rework of the code. So if code grows over time without having a good architecture a rework would be the the best. Also if it is hard work or a hard job the result will be a mor structured code. |
platform.getId() gives the same result for derived cores. Issue arduino#5260 is caused by both cores declaring as `avr`, with the same label but different identifier. This patch completes the previous one by adding the folder where the core resides to the matching id.
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8880-BUILD-858-linux32.tar.xz ℹ️ The |
|
The issue no longer occurs for me using build 858. Great work @facchinm! |
Fixes #5260
@per1234 @hasenradball can you test in your environment too? Thanks!