Draft
Conversation
the issue solved is tcp window were missing and that was due to: - ACK were sent as soonas packets were received and not when they were consumed by the application layer - pbufs where not cleared correctly and following lwip indications
This reverts commit c2db54f.
Contributor
Author
|
@Eduardo-Lopes sorry, I forgot to add a part of the fix |
|
@andreagilardoni the DHCP is solved, but still there is connection loss when I stress test. |
Contributor
Author
|
@Eduardo-Lopes how are you performing stress tests? So that can better address the issue |
|
I just call a Python script that loops requesting the WebServer on C33. |
Contributor
Author
|
This will take some more time to debug, I think there is a memory leak somewhere I am missing. |
906bab9 to
ec5ea83
Compare
610c14c to
c28b4bd
Compare
|
This problem of instable WebServer is been around for 2-3 years, still not solved? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title states the objective of this PR is the redesign of the network stack of the portenta C33. This PR aims to solve multiple issues that affected reliability, performance and usability of networking.
The main issues addressed are the follwing:
This issue needs arduino/ArduinoCore-API#218 in order to completely fix memory leaking when using a class that is derived from
arduino::Client.Since this work started as a task to address Ethernet bad performances and behavior it was mainly focused on the ethernet improvement. We were able to achieve a speed of ~80Mbit/s in Rx with some fine tuning of the libraries (this require high ram usage) by means of Rx zero copy capabilities of Ra6m5 controller. Wifi drivers were not taken into consideration that deeply, but there is room for improvement, i.e. by reducing the number of
memcpyperformed on buffers.Furthermore some aspects of the integration of lwip have been improved:
This issue is currently on draft, since there are still some imperfections, which are addressed in TODO and FIXME comments. Some will be addressed before this PR is merged and others are going to provide a path to follow for future improvements.