Update Wire peripheral handler #605
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2021
stonehippo
force-pushed
the
master
branch
2 times, most recently
from
3cfed0e to
29fd437
Compare
|
I found a couple of issues that I've resolved, namely that NACKs needed to be sent at the end of the read or write logic to close down the connection. Should be all set now. I'm using a version of this code locally to test out a custom peripheral and so far, it's working as expected (with the NACK fix in place). |
|
I've found bug here (the write NACK prevents reads). I'll fix that and push a revision to the PR. |
|
Ok, last bug (that I've found) smooshed. Would love a review of this and to see it get merged in. |
|
works for me! |
|
It’s been a while since I submitted this PR. The checks failed due to issue that had nothing to do with the changes here. Any idea how to get this re-checked and maybe merged in? @per1234? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing onService method for I2C peripheral (slave) implementation
swapped the sense of onRequest (master read) and onReceive (master
write) handlers. It also didn't handle writes correctly, requiring two
write operations to get bytes out of the buffer and in the onReceive
handler.
This implementation follows the SERCOM I2C flow defined for the
default clock-stretching case (CTRLB.SCLSM=0) as described in the
SAMD21 datasheet.