-
-
Notifications
You must be signed in to change notification settings - Fork 400
Improve clarity of library.properties include= field #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The existing wording doesn't convey the fact that, despite literal reference to `#include`, this setting isn't a directive to the compiler. The updated text makes it more clear that the setting drives a convenience function in the IDE, where text is added to the sketch currently being edited.
My understanding of this contribution is that it's available to you under the terms of the GPLv3, the same license used by this project (which I forked). Can you explain why the rights granted to you by that license are insufficient to accept my contribution? |
@ianfixes there is some helpful information here:
I realize it seems silly to go through this process just to add a few words to the documentation, but it's very fast and easy and only needs to be done once. I'm not sure what the process would be for you to get an exemption from our policy that every contributor must sign the CLA. |
It may be fast and easy to click, but I have to run all this by my employer as well as decide whether I'm prepared to do this for all contributions, ever. I'm hesitant to contribute anything significant to a project that (by nature of this CLA) seems to reserve the right to make itself closed-source. |
@ianfixes Sorry to answer after this long time - I had missed the notification. I understand you being hesitant, so I'll try to give some context here. I hope this helps understanding our commitment and the purpose of this required "click" :) |
Closing due to lack of signed CLA |
The tone of this thread left a very bad taste in my mouth, and left me with less desire to contribute than when I first started. My question about the CLA was "why is the GPLv3 license on my code insufficient", and the answer was:
Unsatisfying and ominous (since even future adoption of the Commons Clause would be a step backwards in terms of rights). But this statement really bothered me:
You are asking me to make a commitment in the form of a legal document, while your commitment is nothing more than a comment on a GitHub issue thread. The real commitment to open source here would be to simply use inbound = outbound, and abide by the current GPLv3 licensing on this project. |
Docs update
The existing wording for the
library.properties
fieldinclude=
doesn't convey the fact that, despite literal reference to#include
, this setting isn't a directive to the compiler.The updated text (below) makes it more clear that the setting drives a convenience function in the IDE, where text is added to the sketch currently being edited.