Skip to content

Fix board attach panic if sketch.json doesn't exist #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2021
Merged

Fix board attach panic if sketch.json doesn't exist #1405

merged 1 commit into from
Aug 24, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes a panic in a CLI command.

  • What is the current behavior?

Calling board attach with a sketch that doesn't have a sketch.json file makes the CLI panic.

  • What is the new behavior?

Calling board attach with a sketch that doesn't have a sketch.json file doesn't panic anymore.

Nope.

  • Other information:

None.

See how to contribute

@silvanocerza silvanocerza self-assigned this Aug 23, 2021
@silvanocerza silvanocerza force-pushed the scerza/fix-attach-panic branch from d80cd45 to 86510f4 Compare August 24, 2021 07:27
@silvanocerza silvanocerza force-pushed the scerza/fix-attach-panic branch from 86510f4 to cd65ab5 Compare August 24, 2021 07:30
@silvanocerza silvanocerza merged commit b9b7a87 into master Aug 24, 2021
@silvanocerza silvanocerza deleted the scerza/fix-attach-panic branch August 24, 2021 09:34
@rsora rsora added type: imperfection Perceived defect in any part of project topic: CLI Related to the command line interface labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@per1234 per1234 per1234 approved these changes

Assignees

@silvanocerza silvanocerza

Labels
topic: CLI Related to the command line interface type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silvanocerza @cmaglie @per1234 @rsora