Skip to content

[skip-changelog] legacy: some simple refactorings #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 8, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 7, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Some simple refactorings to legacy package

What is the current behavior?

What is the new behavior?

No changes

Does this PR introduce a breaking change, and is titled accordingly?

Other information

This is part of #1766

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 7, 2023
@cmaglie cmaglie self-assigned this Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 82.27% and project coverage change: -0.01 ⚠️

Comparison is base (8310d01) 62.80% compared to head (e6b20fe) 62.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2206      +/-   ##
==========================================
- Coverage   62.80%   62.80%   -0.01%     
==========================================
  Files         219      218       -1     
  Lines       19469    19462       -7     
==========================================
- Hits        12228    12223       -5     
+ Misses       6156     6154       -2     
  Partials     1085     1085              
Flag Coverage Δ
unit 62.80% <82.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
legacy/builder/container_find_includes.go 72.02% <79.68%> (+1.74%) ⬆️
legacy/builder/types/types.go 80.00% <83.33%> (+1.87%) ⬆️
arduino/libraries/librarieslist.go 86.11% <100.00%> (ø)
legacy/builder/types/accessories.go 100.00% <100.00%> (+11.76%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie force-pushed the some_refactorings branch from c8beda0 to e6b20fe Compare June 7, 2023 16:01
@cmaglie cmaglie requested a review from alessio-perugini June 7, 2023 16:20
@cmaglie cmaglie merged commit 8cd7297 into arduino:master Jun 8, 2023
@cmaglie cmaglie deleted the some_refactorings branch June 8, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants