[skip-changelog] Add output.no_color to configuration docs
#2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
MatteoPologruto
force-pushed
the
no-color-docs
branch
from
4523941 to
adb9a4a
Compare
MatteoPologruto
changed the title
output.no_color to configuration docs
3 tasks
alessio-perugini
approved these changes
Jul 18, 2023
per1234
reviewed
Jul 18, 2023
There was a problem hiding this comment.
I would suggest also adding these properties to https://github.com/arduino/arduino-cli/blob/master/configuration/configuration.schema.json
It could be argued that is out of scope for the PR that is only intended to update the docs, but it seems the approach taken during the creation of the schema was to provide coverage only for the documented configuration properties rather than all the properties implemented in the Arduino CLI codebase.
The documentation looks perfect.
|
Thanks for the suggestion @per1234! I updated the |
umbynos
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Documentation enhancement
What is the new behavior?
An explanation for the configuration key
output.no_colorhas been added to the docs.Does this PR introduce a breaking change, and is titled accordingly?
No