Skip to content

[skip changelog] Replace gender-specific grammar in package_index.json specification #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2020
Merged

[skip changelog] Replace gender-specific grammar in package_index.json specification #811

merged 1 commit into from
Jul 10, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jul 9, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Docs update.

  • What is the current behavior?

package_index.json specification contains gender-specific grammar.

  • What is the new behavior?

package_index.json specification uses singular "their" in place of gender-specific grammar.

  • Does this PR introduce a breaking change?

No.

  • Other information:

This violates traditional rules of grammar. I don't think that's a problem, but there is the altenative of rewording the sentence to dodge the issue entirely:

Many different index files coming from different vendors may be in use, so vendors should name their own index files in a way that won't conflict with others.

However, I feel this makes the meaning of the sentence slightly less clear.

@per1234 per1234 added the topic: documentation Related to documentation for the project label Jul 9, 2020
@per1234 per1234 merged commit 77efe67 into arduino:master Jul 10, 2020
@per1234 per1234 deleted the replace-gender-specific-grammar branch July 10, 2020 11:51
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants