Skip to content

[skip changelog] Clarify in documentation that the upload command will not compile beforehand #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Aug 25, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

docs update

  • What is the current behavior?

The upload command documentation does not specify that the sketch isn't compiled prior to upload. I thought this would be a helpful clarification since that's the behavior in the Arduino IDE.

  • What is the new behavior?

The upload command documentation clarifies that the upload command does not compile the specified sketch.

  • Does this PR introduce a breaking change?

No, doc changes.

@ghost ghost changed the title Clarify in documentation that the upload command will not compile beforehand [skip changelog] Clarify in documentation that the upload command will not compile beforehand Aug 24, 2020
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tc333!

@per1234 per1234 merged commit 9ff9308 into arduino:master Aug 25, 2020
@ghost
Copy link
Author

ghost commented Aug 25, 2020

My first ever open source contribution! Woo!

@ghost ghost deleted the upload_documentation_clarification branch August 25, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants