Skip to content

Fix the circuit image in the Knock built-in example #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chiepomme
Copy link

@chiepomme chiepomme commented Jul 2, 2022

Hi! I'm a beginner in Arduino and was trying the Knock built-in example. Then I noticed that the circuit image differed from the schematic image, so I tried fixing it. I don't know what tool was used to create the circuit image, so I fixed it with Fritzing.

My apologies if I overlooked something.

What This PR Changes

  • Fix the circuit image in the Knock built-in example to match the schematic image.

Contribution Guidelines

The circuit image differed from the schematic image.
@marqdevx
Copy link
Member

marqdevx commented Jul 5, 2022

Thanks for your PR!
Let me tag my colleague who has a better design view than me 😄

Could you please check / update the drawing? @jhansson-ard

@marqdevx marqdevx added fix/update A small fix or update Tutorial community Bugs and fixes suggested by the community labels Jul 5, 2022
@jhansson-ard
Copy link
Contributor

jhansson-ard commented Jul 12, 2022

@chiepomme please check out this PR here #344 if the new graphics are good enough! Thank you 🙏🏼

@chiepomme
Copy link
Author

@jhansson-ard Hi! I checked it! The new graphics are great, and the new explanation about the resistor and piezo is really useful especially for newbies like me. Thank you for accepting my suggestion and improving the doc!

Btw, thanks to the Knock tutorial, I was able to make an VR experience that a girl copies player's play. I really appreciate the tutorial!
https://twitter.com/chiepomme/status/1544272386953949184

@jhansson-ard
Copy link
Contributor

That looks amazingly cool @chiepomme! Thank you for sharing! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Bugs and fixes suggested by the community fix/update A small fix or update Tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants