Skip to content

Ensure canonical path on MkTempDir (windows) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 18, 2021

No description provided.

@cmaglie cmaglie changed the title Added test for canonical tmp path on windows Ensure canonical path on MkTempDir (windows) May 18, 2021
@cmaglie cmaglie force-pushed the fix_tmp_canonical_paths branch from b868adf to bbb420d Compare May 19, 2021 14:04
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #9 (bbb420d) into master (5a57733) will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   65.54%   65.91%   +0.37%     
==========================================
  Files           4        4              
  Lines         267      267              
==========================================
+ Hits          175      176       +1     
+ Misses         64       63       -1     
  Partials       28       28              
Flag Coverage Δ
unit 65.91% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
constructors.go 56.25% <100.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a57733...bbb420d. Read the comment docs.

@cmaglie cmaglie merged commit 3d2c600 into master May 19, 2021
@cmaglie cmaglie deleted the fix_tmp_canonical_paths branch May 19, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants