AsmAnalysis: Fix out of bounds read due to incorrect bounds checking … #10611
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on literal arguments
chriseth
approved these changes
Dec 15, 2020
Contributor
|
The change looks good, but I was not able to reproduce the bug. |
Contributor
Author
I had to comment out the |
Contributor
|
Can you explain why this problem can happen? Especially for a non-builtin function, ilteralArguments should always be nullptr. |
Contributor
Author
Ah, sorry. The tests added don't correspond to the fix. As you said, I incorrectly assumed literal arguments are non null for user defined functions. Please see the new PR with the missing test case that fixes the out of bounds read. PR #10613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on literal arguments
Fixes #10609