Refactor: Remove some clippy allows - #199
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRust lint suppressions are reduced, Python binding error-handling syntax is modernized, and YAML writer tests use explicit failure handling and bitwise float comparisons. ChangesRust lint and test cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 85 85
Lines 15613 15613
=======================================
Hits 13859 13859
Misses 1754 1754
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@rust/yaml-parser/tests/writer_basic.rs`:
- Around line 123-129: Update the error branches around write_yaml_from_events
and String::from_utf8 to bind each Err value and include it with {:?} in the
panic messages, preserving the underlying writer and UTF-8 conversion errors
while retaining the existing success behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3e13df8c-d589-49d0-a420-3203d6ec2a08
📒 Files selected for processing (5)
rust/avdschema/src/schema/dict/mod.rsrust/python-bindings/src/lib.rsrust/python-bindings/src/schema_store/mod.rsrust/python-bindings/src/tests/validation.rsrust/yaml-parser/tests/writer_basic.rs
💤 Files with no reviewable changes (1)
- rust/python-bindings/src/lib.rs
|
@ClausHolbechArista This is uncovered before refactor so Codecov failure can be ignored |
Change Summary
Continuing on the work to remove clippy allows that were added when adding workspace lint on all the crates
Checklist
Repository Checklist
Summary by CodeRabbit
Bug Fixes
Tests