Skip to content

Conversation

@z-tech
Copy link
Contributor

@z-tech z-tech commented Nov 10, 2025

Description

The CI has started giving an error that the unsafe block is not needed. However, the unsafe block cannot be removed and thus needs to be decorated with allow unused_unsafe.

closes: #1060


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@z-tech z-tech changed the title fix uneccesary unsafe code block error Decorate unsafe code block with allow unused_unsafe Nov 10, 2025
@z-tech z-tech marked this pull request as ready for review November 10, 2025 15:46
@z-tech z-tech requested review from a team as code owners November 10, 2025 15:46
@z-tech z-tech requested review from Pratyush, mmagician and weikengchen and removed request for a team November 10, 2025 15:46
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which versions of Rust does this error happened.

@z-tech
Copy link
Contributor Author

z-tech commented Nov 10, 2025

In which versions of Rust does this error happened.

nightly-x86_64-unknown-linux-gnu installed - rustc 1.93.0-nightly (6647be936 2025-11-09)

@weikengchen
Copy link
Member

I feel that we just need to keep a note somewhere to remove this unused_unsafe when our target version (rust-version in cargo, currently 1.75) gets to 1.93.0 one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decorate unsafe code block with allow unused_unsafe

4 participants