Add week, weeks to timeframes in class ThaiLocale #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1218 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2324 2335 +11
Branches 357 357
=========================================
+ Hits 2324 2335 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Hope1010 Thanks for contributing! Can you just run pre commit to fix up the linting errors? Cheers |
Yes, I will try. |
|
The reason the system tests are failing on Windows is because dateutil.tz doesn't recognize the new timezone 'America/Coyhaique'. This doesn't seem to be related to the code I modified, and it looks like I don't need to fix this part, do I? 🤔 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Add week, weeks to timeframes in class ThaiLocale for fixing
"ValueError: Humanization of the 'weeks' granularity is not currently translated in the 'th' locale. Please consider making a contribution to this locale"