The reactive form model class cannot have a constructor with non-nullable fields

[efraimbart]

When the generated code constructs the model class it uses null propagation to get the corresponding property from the original model instance, thereby attempting to pass in a nullable version of the expected property type.

An example of where this issue can be seen is in login_extended. It's only not an issue in this instance because LoginExtended.unAnnotated is nullable, but if it's changed to non-nullable it would cause a compile time error.

The one example I've seen where it set the model as nullable, and therefore doesn't require null propagation when accessing it's properties, is in profile, but I don't know how to replicate.

[vasilich6107]

but if it's changed to non-nullable it would cause a compile time error.

Hi. If it will change to non nullable - you have to regenerate the code.

May be you can provide more details about your issue

[efraimbart]

I've regenerated the code with the property as a non-nullable and it continued to treat it as nullable. That's essentially the issue I'm reporting.

I've made some more changes and it's no longer doing that, but I'm not sure what caused it. Perhaps adding an id property to the model?

I now have another similar issue where it's trying to pass the id property into the constructor as a named argument despite the constructor requiring it as a positional arguments, causing compile time errors.

[efraimbart]

@vasilich6107 I've forked the repo and created two branches with updated examples to show the above issues.

1. Nullable values passed into non-nullable parameters.
2. Named arguments used when positional arguments expected.

If you need any more clarification just let me know, thanks!

[efraimbart]

@vasilich6107 Any thoughts on the above?

[vasilich6107]

HI @efraimbart
I took first example

It generates slightly different code

Login model becomes required no as far as it has non nullable required values to pass through

[vasilich6107]

case 2 fixed in reactive_forms_generator 0.23.3

[efraimbart]

HI @efraimbart I took first example

It generates slightly different code

Login model becomes required no as far as it has non nullable required values to pass through

The difference between my generated code and your generated code is probably because in the model I put required this.nonNullable = '' while you put required this.nonNullable. Perhaps the default value causes the generator to treat the parameter as nullable, but that doesn't work in dart (see dart-lang/language#219).

[efraimbart]

case 2 fixed in reactive_forms_generator 0.23.3

Great, will try this in a bit.

[vasilich6107]

@efraimbart could you clarify if the issue is fixed

[efraimbart]

I'm in the midst of a refactor so I haven't had a chance to try it yet, but I'll try to get to it very soon.

[efraimbart]

Issue 2 seems resolved, but issue 1 still seems to be active.

[vasilich6107]

Hi @efraimbart
The issue in the model definition

[vasilich6107]

Fix your model and you'll get the proper result

[vasilich6107]

Closing the issue as far as we fixed one thing and identified the fix for another one.