file descriptor leak

[andrew-ld]

Expected behavior
file should be closed

Current behavior
dont close files after command execution

To Reproduce
compile and install a debuggable application that use ffmpegkit

ex:
FFmpegKit.executeAsync("-hide_banner -y -f s16le -ar 16000 -i $pcmPath -ac 1 -c:a libvorbis -f ogg $oggPath")

now:
adb shell
run-as [package name]
lsof | grep [package name]

you will see that the input and output files remain open after command execution

Screenshots

^^leaked file descriptor

Environment

• Platform: Android
• Architecture: all
• Version: 4.4 lts
• Source branch: last commit (tanersener@46afc3f)
• Android Studio version: 4.1.3
• Android NDK version: 21.4.7075529

[andrew-ld]

@tanersener the same application using mobile-ffmpeg instead of ffmpegkit does not have this problem

[tanersener]

In ffmpeg-kit we have a native saf protocol implementation. That implementation changes how files are opened and closed. There might be a problem there. But, it must be analysed first. And lsof doesn't work on all devices. So, it is not an easy case to test.

[andrew-ld]

you should run lsof using the user of the app using run-as

[tanersener]

Thanks for reporting this issue. My tests confirm that there is a problem there. input and output files are not closed after the execution completes.

This issue originates from Scoped Stored PR of mobile-ffmpeg. I guess we missed this during the review. I'll look into this but it will take time to fix it.

[tanersener]

Fixed in development.