Upgrade artichoke dependency to latest trunk #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artichoke only compiles with Rust 1.54.0. Rust 1.54.0 is based on LLVM 12 (rust-lang/rust#81451). To ensure the `emcc` compiled sources interop with Rust code, it is important to use an `emsdk` version that is ~close to when it was branched from LLVM 12. According to the release notes [0], 2.0.23 - 05/26/2021 release is the first to be based on LLVM 12. However, Rust depends on a stubbed function in the emsdk c++ ABI that was removed in 2.0.10. According to rust-lang/rust#85821, we might have luck compiling with 2.0.9 [0]: https://emscripten.org/docs/introducing_emscripten/release_notes.html emscripten-toolchain
|
This PR is blocked on artichoke/artichoke#1308. |
lopopolo
added
the
S-blocked
lopopolo
force-pushed
the
upgrade-artichoke
branch
from
e62b8be to
8736408
Compare
lopopolo
removed
the
S-blocked
lopopolo
added
the
S-blocked
|
Blocked on artichoke/artichoke#1309. |
artichoke/artichoke@e7c4bd5 This upgrade bumps the MSRV to Rust 1.54.0 and includes an updated set of emsdk headers for the artichoke-backend build to match the current playground's emscripten toolchain.
|
Filed this bug upstream for a build warning due to a duplicate |
lopopolo
force-pushed
the
upgrade-artichoke
branch
from
8736408 to
0366fc6
Compare
|
Smoke test as of 0366fc6 and artichoke/artichoke@5b0b0e5 looks good!
|
lopopolo
added
A-wasm-build-target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the artichoke git dependency to the latest trunk commit: artichoke/artichoke@e7c4bd5.
This PR upgrades the Rust toolchain to 1.54.0 to match upstream Artichoke's toolchain. The emscripten toolchain is correspondingly bumped (see rust-lang/rust#85821).
This PR includes upstream changes to remove the
bindgenbuild dependency, which removes some licenses from the allowed list in thecargo-denyconfiguration.