feat: Provide web gui for {list, add, add, update, remove} repository…#106
Merged
Merged
Conversation
olenagerasimova
requested changes
Oct 24, 2022
olenagerasimova
left a comment
olenagerasimova
left a comment
Member
There was a problem hiding this comment.
@andpopov thanks, check my comment and
- the main idea to remake front was to avoid it to depend on the same config as Artipie, so front should not use
artipie.yamlas settings, Artipie API url should be eventually the only setting required for front to work. - I think API endpoint should be removed, so they do not complicate current code and do not lead to any not required changes in the code
- design issues: will we work on design later? Now, at least, working (I've colored it with blue) area is not in the middle of the page...
There is no need to fix these three comments in this PR, but they can definitely should be addressed later.
| * @param <V> Type of resulting of map-function. | ||
| * @return Triple-tuple. | ||
| */ | ||
| protected static <V> Tuple3<Integer, V, String> handle(final int success, |
Member
There was a problem hiding this comment.
There tuples with several items does not look clear and it's not convenient to use them: you should always know what item represents and perform various checks...
Spark has error handling and exception mappers, maybe we can throw some custom exception on error from Artipie API and handle it with spark? Thus no tuples with nulls and no checks will be required...
olenagerasimova
approved these changes
Oct 24, 2022
olenagerasimova
left a comment
olenagerasimova
left a comment
Member
There was a problem hiding this comment.
@andpopov approving as we discussed
andpopov
added a commit
that referenced
this pull request
Oct 28, 2022
* feat: Singn in and obtaining JWT-token (#103) * feat: Singn in and obtaining JWT-token * feat: Provide web gui for {list, add, add, update, remove} repository… (#106) * feat: Provide web gui for {list, add, add, update, remove} repository settings * add standard artipie authentication * Start web gui without artipie yaml configuration (#107) feat: start dashboard without config * Remove rest services from frontend (#108) feat: remove rest services from front
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #105
@olenagerasimova, @dgarus Please review