refactor: reset push token on logout#13525
Open
gkartalis wants to merge 3 commits into
Open
Conversation
Contributor
🎉 Beta Versions Generated (commit:
|
gkartalis
force-pushed
the
gkartalis/PHIRE-3028
branch
from
08a9359 to
5e787a8
Compare
Contributor
Contributor
🎉 Beta Versions Generated (commit:
|
MounirDhahri
approved these changes
May 4, 2026
Member
MounirDhahri
left a comment
MounirDhahri
left a comment
There was a problem hiding this comment.
LGTM! I think without the API call to delete the token, we can never be sure.
| } | ||
|
|
||
| try { | ||
| await fetch(new Request(url, { method: "DELETE", headers })) |
MrSltun
approved these changes
May 4, 2026
Member
MrSltun
left a comment
MrSltun
left a comment
There was a problem hiding this comment.
I like it 🌟
Let's test and see if it works :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-3028
Description
This PR is about reseting the push token anytime a user logs out of the app so multiple users can use the app without conflicts on their notifications.
Also users on logging out stop receiving notifications.
It is more of a conversation starter PR to make sure that we do want this behavior or not.
On the end of this PR we can find the latest betas that we can use in order to test this.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.