fix: images posted to server via fetch get their size inflated significantly for iOS #6749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimatretyak
force-pushed
the
dimatretyak/fix/resized-image-size-for-ios
branch
from
fc979fd to
c6079fe
Compare
dimatretyak
changed the title
dimatretyak
changed the title
gkartalis
previously approved these changes
May 16, 2022
Yes, I think it would not be superfluous to do this |
dblandin
reviewed
May 16, 2022
|
|
||
| #### When we can remove this: | ||
|
|
||
| When this problem will be fixed in one of the next React Native releases (fixes were already added in 0.66.4, but were eventually [reversed](https://github.com/facebook/react-native/commit/e83feffeba567b4e304181632128ee1caa036c45)) |
There was a problem hiding this comment.
praise: This is great context to capture. Thank you!! 👏🏼
dblandin
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR #6743
Description
While testing the beta build, I noticed a strange behavior on iOS: when I tried to upload a file, I received an error saying that the maximum allowed file size was exceeded (although the same file was uploaded on Android without any problems). It turned out that the problem has been around for a long time in React Native and and you can find a discussion of it here.
Solution based on this comment
Demo
Before
before.mp4
After
after.mp4
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.