Add clearSubject before setSubject#57
Closed
kassner wants to merge 2 commits intoaschroder:masterfrom
kassner:master
Closed
Add clearSubject before setSubject#57kassner wants to merge 2 commits intoaschroder:masterfrom kassner:master
kassner wants to merge 2 commits intoaschroder:masterfrom
kassner:master
Conversation
Owner
|
Thanks for the pull request. I too have seen this error, and I agree that the extension could prevent it by clearing the subject right before setting it just as you have suggested. However, I do not think this change should be made in SMTP Pro. The parts of the extension where you suggest modification mirror the core Magento functionality intentionally. This is important so that any email that did or did not send in core Magento, will have the same behavior in SMTP Pro. I'll close this PR but suggest any one facing the subject set twice error coms here for a patch. |
|
Does it support Multi-Website Magento Email configurations for different servers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a very few cases, I'd experienced some
Subject set twiceexceptions. We can clear the subject before to avoid any exception.