Skip to content

Fix problem with regular expression to grab go version from go.mod#166

Open
trevorackerman wants to merge 4 commits into
asdf-community:masterfrom
trevorackerman:fix-parse-go-mod
Open

Fix problem with regular expression to grab go version from go.mod#166
trevorackerman wants to merge 4 commits into
asdf-community:masterfrom
trevorackerman:fix-parse-go-mod

Conversation

@trevorackerman

@trevorackerman trevorackerman commented Oct 23, 2025

Copy link
Copy Markdown

parse-legacy-file against a go.mod file with the directive

go 1.x.y

is not honoring the version of go specified in go.mod.
It is calculating GOLANG_VERSION to be 1 in function get_legacy_version()

The regular expression needs to include . characters in addition to digits.

Tested this with gnu sed version 4.9 and builtin sed on MacOS 15.6


Note

Adjusts the sed regex in get_legacy_version to include dots when extracting the Go version from go.mod/go.work directives.

  • Scripts:
    • Update bin/parse-legacy-fileget_legacy_version to widen the sed match from s/go([0-9]+).*/\1/ to s/go([0-9]+.).*/\1/, enabling extraction of dotted Go versions from go.mod/go.work go directives.

Written by Cursor Bugbot for commit 7b34481. This will update automatically on new commits. Configure here.

@trevorackerman
trevorackerman requested a review from a team as a code owner October 23, 2025 23:45
@smorimoto

Copy link
Copy Markdown
Member

bugbot run

Comment thread bin/parse-legacy-file Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants