Skip to content

[x11] Fix file drops from Wayland sources#179

Closed
SanjoSolutions wants to merge 1 commit into
aseprite:mainfrom
SanjoSolutions:fix-xwayland-file-drops
Closed

[x11] Fix file drops from Wayland sources#179
SanjoSolutions wants to merge 1 commit into
aseprite:mainfrom
SanjoSolutions:fix-xwayland-file-drops

Conversation

@SanjoSolutions

Copy link
Copy Markdown

Summary

  • keep pending Xdnd drop state alive when XWayland sends XdndLeave immediately after XdndDrop
  • retry file-data selection conversion with common Wayland/XDG portal targets when text/uri-list is unavailable
  • tighten URI-list parsing for CRLF, comments, localhost file URIs, and plain-path fallback payloads

Testing

  • Built Aseprite with cmake --build build --target aseprite
  • Installed locally and verified dragging a file from GNOME Files into an Aseprite window opens the file on Ubuntu 25.10 / GNOME 49 Wayland

Context: aseprite/aseprite#1410

Co-authored-by: Codex <codex@openai.com>
@SanjoSolutions SanjoSolutions force-pushed the fix-xwayland-file-drops branch from 4793e08 to e446482 Compare May 15, 2026 09:51
@SanjoSolutions

Copy link
Copy Markdown
Author

I have fixed the linter formatting errors.

@dacap

dacap commented May 29, 2026

Copy link
Copy Markdown
Member

Sorry @SanjoSolutions, I saw that you've used Codex to create your patch, we're not accepting PRs co-authored by AI. I'll close this PR and add a note about this in the PR template (Aseprite already have the note).

@dacap dacap closed this May 29, 2026
@SanjoSolutions

Copy link
Copy Markdown
Author

Ok. I hope that it is still fixed, so other Linux users receive the same benefit. You can also copy the changes from the PR (I give you MIT-0 permissions).

While I don't care much about your choices, I would recommend to reconsider your policy and make it more reasonable.

Best regards
Jonas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants