Skip to content

[FIX] RequestLogger middleware to handle Grape 2.4 breaking change #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devsigner
Copy link

No description provided.

Copy link

@joseairosa joseairosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

We should probably upversion to 1.9 as well

@yungtrizzle
Copy link
Contributor

this should resolve #82

@samsonjs
Copy link
Collaborator

Ok so we're on version 2.1 as of today, and I was thinking we could bump this to version 3.0 for this change since it's breaking and that follows semantic versioning which is good for libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants