Prepare for 2.0.0 release #89
Conversation
RELEASING.md
Outdated
| git push github master | ||
| ``` | ||
|
|
||
| Release. |
There was a problem hiding this comment.
Suggestion: We might want to add that when releasing, create a GitHub release containing release notes too? (this might be done already by the rake release and I'm not well informed)
There was a problem hiding this comment.
Suggestion (optional): The only other thing we might want to add is to setup MFA to be required for rubygems publishing - https://guides.rubygems.org/mfa-requirement-opt-in/ - to reduce the risk of an account compromise leading to dodgy stuff being published.
There was a problem hiding this comment.
Yes to both. @aserafin I'm unsure whether you need to enable mandatory MFA on the rubygems side.
And I still need to nab the release rake task from grape-active_model_serializers which is where the contributing and releasing docs are from.
There was a problem hiding this comment.
Apparently this is a feature of rubygems itself and we get it by requiring gem_tasks in our Rakefile. I haven't maintained many gems and I had no idea this existed 😆 https://schneems.com/blogs/2016-03-18-bundler-release-tasks
There was a problem hiding this comment.
Added in c147718 with a rake task to do the whole shebang too.
|
@samsonjs I added you as owner to the gem 🥳 you should receive invitation email 👍 |
|
Thanks so much @aserafin I'm in! I'll try to release 2.0 in the next week or two. |
Added a changelog. I'm still waiting on rubygems access to do the release.