Skip to content

remove some unneeded calls to _partitions_to_src #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2022
Merged

remove some unneeded calls to _partitions_to_src #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions reorder_python_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,7 @@ def partition_source(src: str) -> list[CodePartition]:
chunks.append(CodePartition(CodeType.CODE, srctext))
break

chunks = [chunk for chunk in chunks if chunk.src]

# Make sure we're not removing any code
assert _partitions_to_src(chunks) == src
return chunks
return [chunk for chunk in chunks if chunk.src]


def combine_trailing_code_chunks(
Expand Down Expand Up @@ -380,16 +376,6 @@ def apply_import_sorting(
if new_imports:
new_imports.pop()

# There's the potential that we moved a bunch of whitespace onto the
# beginning of the rest of the code. To fix this, we're going to combine
# all of that code, and then make sure there are two linebreaks to start
restsrc = _partitions_to_src(rest)
restsrc = restsrc.rstrip()
if restsrc:
rest = [CodePartition(CodeType.CODE, restsrc + '\n')]
else:
rest = []

return pre_import_code + new_imports + rest


Expand Down