-
Notifications
You must be signed in to change notification settings - Fork 547
Support ASP.NET 5 using RC1 #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ASP.NET 5 using RC1 #438
Conversation
Move the parameters into a local variable before passing to the FormUrlEncodedContent constructor so that it's easier to make nullable annotations happier in .NET 5 (see aspnet-contrib#438).
Move the parameters into a local variable before passing to the FormUrlEncodedContent constructor so that it's easier to make nullable annotations happier in .NET 5 (see #438).
31b82d5
to
30057c9
Compare
380246a
to
9773507
Compare
Once RC1 lands (after preview 8), I'll look at merging this to a |
For RC1 we can use the new "one-shot" hash methods (dotnet/aspnetcore#24696) in these two providers: AspNet.Security.OAuth.Providers/src/AspNet.Security.OAuth.Deezer/DeezerAuthenticationHandler.cs Line 131 in 28f6c0d
Line 42 in 28f6c0d
We can also leverage the new Lines 80 to 90 in 28f6c0d
|
9773507
to
fb1e5f2
Compare
I think something in Arcade needs updating somewhere, as now the build gets this error with preview 8:
Vanilla |
Updates to support ASP.NET 5, using preview 6. Remove obsolete members.
Update to preview 5 of ASP.NET 5.
Update to preview 8 of ASP.NET 5.
Update the version metadata to align with ASP.NET Core, so we generate prerelease labels like "preview.8." or "rc.1.".
47884e4
to
064688d
Compare
src/AspNet.Security.OAuth.VisualStudio/VisualStudioAuthenticationDefaults.cs
Outdated
Show resolved
Hide resolved
Update to RC1 of ASP.NET 5.
Use new HashData() methods for SHA256 and MD5. Use Convert.ToHexString().
See #472. |
This PR adds support for ASP.NET 5, starting with preview 6 through to RC1.