Skip to content

Properly handle malformed request body and content type #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2020
Merged

Properly handle malformed request body and content type #320

merged 2 commits into from
Nov 21, 2020

Conversation

aliniknejad
Copy link
Contributor

@aliniknejad aliniknejad commented Nov 21, 2020 •
edited
Loading

Hi @JamesNK

This PR includes two changes to gRPC Http API:

  • For incorrect content-type, which is currently anything but application/json, it will return a 400 http error code, rather than 500.
  • For malformed request body payloads, whether it's a malformed json or it doesn't conform to the request type, it will return 400 with the appropriate error message.

Properly handle malformed request body and content type
6564643 
This will ensure a 400 http status will be returned, signalling the input error, with appropriate error message and gRPC status code.
@ghost
Copy link

ghost commented Nov 21, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

JamesNK
JamesNK approved these changes Nov 21, 2020
View reviewed changes
@JamesNK JamesNK merged commit 34782d7 into aspnet:master Nov 21, 2020
@kharabasz
Copy link

Is this change available as a NuGet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliniknejad @kharabasz @JamesNK