Skip to content

Delete src/MvcPrecompilation/** #5124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Dec 15, 2018

- out-of-date and no longer shipped
- related to #3754
@dougbu dougbu requested review from pranavkm and rynowak December 15, 2018 03:45
@pranavkm
Copy link
Contributor

We could remove the comment as part of cleaning up ViewsFeatureProvider (it's marked as obsolete and is intended to be removed in 3.0). The test is also ripe for clean up.

@dougbu
Copy link
Contributor Author

dougbu commented Dec 17, 2018

cleaning up ViewsFeatureProvider

Added some comments to #3654

@dougbu dougbu merged commit 826f950 into master Dec 17, 2018
@dougbu dougbu deleted the dougbu/remove.precompilation.3754 branch December 17, 2018 02:29
@rynowak
Copy link
Member

rynowak commented Dec 17, 2018

We could remove the comment as part of cleaning up ViewsFeatureProvider (it's marked as obsolete and is intended to be removed in 3.0). The test is also ripe for clean up.

Note that I have a change in progress to obsolete RazorViewAttribute and RazorPageAttribute. That has to happen in the tooling repo first since the SDK generates those attributes right now for 3.0 projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants