Skip to content

Evaluate obsolete APIs from 2.2 and consider removing them in 3.0.0 #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aspnet-hello opened this issue Oct 17, 2018 · 12 comments
Closed

Evaluate obsolete APIs from 2.2 and consider removing them in 3.0.0 #3654

aspnet-hello opened this issue Oct 17, 2018 · 12 comments
Assignees
@Eilon
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework breaking-change This issue / pr will introduce a breaking change, when resolved / merged.
Milestone
3.0.0-preview4

Comments

@aspnet-hello
Copy link

From @Eilon on Thursday, January 11, 2018 11:54:54 AM

In theory, when we start working on 3.0.0, we should delete all APIs that have been marked as [Obsolete]. There could be exceptions to that, but we should at least look.

Copied from original issue: aspnet/Universe#776
@aspnet-hello
Copy link
Author

From @davidfowl on Thursday, January 11, 2018 12:04:43 PM

👍

@aspnet-hello aspnet-hello added this to the 3.0.0 milestone Oct 17, 2018
@aspnet-hello aspnet-hello added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework breaking-change This issue / pr will introduce a breaking change, when resolved / merged. labels Oct 17, 2018
@aspnet-hello
Copy link
Author

From @Eilon on Thursday, January 11, 2018 1:21:50 PM

cc @DamianEdwards as well.

@aspnet-hello
Copy link
Author

From @Eilon on Thursday, January 11, 2018 1:22:01 PM

And credit to @kichalla for the idea 😄

@aspnet-hello
Copy link
Author

From @rynowak on Sunday, January 14, 2018 5:40:50 PM

That's a cool original idea. Bravo @kichalla

@aspnet-hello aspnet-hello mentioned this issue Oct 17, 2018
Closed
@muratg muratg modified the milestones: 3.0.0-preview1, 3.0.0-preview2 Nov 30, 2018
@dougbu
Copy link
Contributor

dougbu commented Dec 17, 2018

W.r.t. ViewsFeatureProvider and related cleanup, see exchange between me and @pranavkm in #5124:

Is the following comment still correct?
https://github.com/aspnet/AspNetCore/blob/3c09d644cccdb21801f7a79e1188a1a1212de5d9/src/Mvc/src/Microsoft.AspNetCore.Mvc.Razor/DependencyInjection/MvcRazorMvcCoreBuilderExtensions.cs#L67-L70

And, should we remove the "faking" done in src\Mvc\test\WebSites\RazorBuildWebSite\RazorBuildWebSite.csproj and its sisters?
https://github.com/aspnet/AspNetCore/blob/3c09d644cccdb21801f7a79e1188a1a1212de5d9/src/Mvc/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj#L13-L15

We could remove the comment as part of cleaning up ViewsFeatureProvider (it's marked as obsolete and is intended to be removed in 3.0). The test is also ripe for clean up.

@dougbu dougbu mentioned this issue Dec 17, 2018
Merged
@rynowak
Copy link
Member

rynowak commented Dec 17, 2018

I volunteer for all of the ViewsFeatureProvider stuff. I already have work in progress.

@natemcmaster
Copy link
Contributor

Triage team: @Eilon can you look over remaining 3.0 code and see if there any obsolete members left to be removed? If so, let's open items for individual area owners.

@Eilon
Copy link
Contributor

Eilon commented Jan 28, 2019 •
edited by muratg
Loading

Here's everything marked obsolete in 'master' in this repo. Please use the links below to compare master and release/2.2 to see if this is a pre-existing obsolete message for a member that can now be deleted. For each item consider whether to log a bug because we will take an action, and then check the checkbox to mark it as done (even if there's no further action).

(1) src\Antiforgery\src\AntiforgeryOptions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Name) + ".")]
        public string CookieName { get => Cookie.Name; set => Cookie.Name = value; }

(2) src\Antiforgery\src\AntiforgeryOptions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Path) + ".")]
        public PathString? CookiePath { get => Cookie.Path; set => Cookie.Path = value; }

(3) src\Antiforgery\src\AntiforgeryOptions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Domain) + ".")]
        public string CookieDomain { get => Cookie.Domain; set => Cookie.Domain = value; }

(4) src\Antiforgery\src\AntiforgeryOptions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is to set " + nameof(Cookie) + "." + nameof(CookieBuilder.SecurePolicy) + ".")]
        public bool RequireSsl
        {

(5) src\Shared\Diagnostics\AttributeValue.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is for internal use only and will be removed in a future version.")]
    public class AttributeValue
    {

(6) src\Shared\Diagnostics\BaseView.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is for internal use only and will be removed in a future version.")]
    public abstract class BaseView
    {

(7) src\Shared\Diagnostics\HelperResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is for internal use only and will be removed in a future version.")]
    public class HelperResult
    {

(8) src\Http\Http\src\HttpContextFactory.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This is obsolete and will be removed in a future version. Use DefaultHttpContextFactory instead.")]
    public class HttpContextFactory : IHttpContextFactory
    {

(9) src\Http\Routing\src\DefaultInlineConstraintResolver.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete. Use DefaultInlineConstraintResolver.ctor(IOptions<RouteOptions>, IServiceProvider) instead.")]
        public DefaultInlineConstraintResolver(IOptions<RouteOptions> routeOptions)
        {

(10) src\Http\Routing\src\IRouteValuesAddressMetadata.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("Route values are now specified on a RoutePattern.")]
    public interface IRouteValuesAddressMetadata
    {

(11) src\Http\Routing\src\RouteValuesAddressMetadata.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("Route values are now specified on a RoutePattern.")]
    public sealed class RouteValuesAddressMetadata : IRouteValuesAddressMetadata
    {

(12) src\Identity\Core\src\BuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete(
            "This method is obsolete and will be removed in a future version. " +
            "The recommended alternative is UseAuthentication(). " +

(13) src\Middleware\StaticFiles\src\StaticFileResponseContext.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("Use the constructor that passes in the HttpContext and IFileInfo parameters: StaticFileResponseContext(HttpContext context, IFileInfo file)", false)]
        public StaticFileResponseContext()
        {

(14) src\Middleware\WebSockets\src\WebSocketMiddleware.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor has been replaced with an equivalent constructor which requires an ILoggerFactory.")]
        public WebSocketMiddleware(RequestDelegate next, IOptions<WebSocketOptions> options)
            : this(next, options, NullLoggerFactory.Instance)

(15) src\Mvc\src\Microsoft.AspNetCore.Mvc.ApiExplorer\DefaultApiDescriptionProvider.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future release.")]
        public DefaultApiDescriptionProvider(
            IOptions<MvcOptions> optionsAccessor,

(16) src\Mvc\src\Microsoft.AspNetCore.Mvc.ApiExplorer\DefaultApiDescriptionProvider.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future release.")]
        public DefaultApiDescriptionProvider(
            IOptions<MvcOptions> optionsAccessor,

(17) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\CompatibilityVersion.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This " + nameof(CompatibilityVersion) + " value is obsolete. The recommended alternatives are " +
            nameof(Version_3_0) + " or later.")]
        Version_2_0,

(18) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\CompatibilityVersion.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This " + nameof(CompatibilityVersion) + " value is obsolete. The recommended alternatives are " +
            nameof(Version_3_0) + " or later.")]
        Version_2_1,

(19) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\CompatibilityVersion.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This " + nameof(CompatibilityVersion) + " value is obsolete. The recommended alternatives are " +
            nameof(Version_3_0) + " or later.")]
        Version_2_2,

(20) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\LocalRedirectResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
        public override void ExecuteResult(ActionContext context)
        {

(21) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\RedirectResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
        public override void ExecuteResult(ActionContext context)
        {

(22) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\RedirectToActionResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
        public override void ExecuteResult(ActionContext context)
        {

(23) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\RedirectToPageResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
        public override void ExecuteResult(ActionContext context)
        {

(24) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\RedirectToRouteResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
        public override void ExecuteResult(ActionContext context)
        {

(25) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\ProblemDetails21Wrapper.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is deprecated and will be removed in a future version")]
    public class ProblemDetails21Wrapper : IXmlSerializable, IUnwrappable
    {

(26) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\ValidationProblemDetails21Wrapper.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is deprecated and will be removed in a future version")]
    public class ValidationProblemDetails21Wrapper : ProblemDetails21Wrapper, IUnwrappable
    {

(27) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\XmlDataContractSerializerInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public XmlDataContractSerializerInputFormatter()
        {

(28) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\XmlDataContractSerializerInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public XmlDataContractSerializerInputFormatter(bool suppressInputFormatterBuffering)
            : this()

(29) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\XmlSerializerInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public XmlSerializerInputFormatter()
        {

(30) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\XmlSerializerInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public XmlSerializerInputFormatter(bool suppressInputFormatterBuffering)
            : this()

(31) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonInputFormatter(
            ILogger logger,

(32) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonInputFormatter(
            ILogger logger,

(33) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonInputFormatter(
            ILogger logger,

(34) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonPatchInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonPatchInputFormatter(
            ILogger logger,

(35) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonPatchInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonPatchInputFormatter(
            ILogger logger,

(36) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonPatchInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonPatchInputFormatter(
            ILogger logger,

(37) src\Mvc\src\Microsoft.AspNetCore.Mvc.TagHelpers\ImageTagHelper.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public ImageTagHelper(
            IHostingEnvironment hostingEnvironment,

(38) src\Mvc\src\Microsoft.AspNetCore.Mvc.TagHelpers\LinkTagHelper.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public LinkTagHelper(
            IHostingEnvironment hostingEnvironment,

(39) src\Mvc\src\Microsoft.AspNetCore.Mvc.TagHelpers\ScriptTagHelper.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public ScriptTagHelper(
            IHostingEnvironment hostingEnvironment,

(40) src\Mvc\src\Microsoft.AspNetCore.Mvc.ViewFeatures\CookieTempDataProviderOptions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Path) + ".")]
        public string Path { get => Cookie.Path; set => Cookie.Path = value; }

(41) src\Mvc\src\Microsoft.AspNetCore.Mvc.ViewFeatures\CookieTempDataProviderOptions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Domain) + ".")]
        public string Domain { get => Cookie.Domain; set => Cookie.Domain = value; }

(42) src\Mvc\src\Microsoft.AspNetCore.Mvc.ViewFeatures\CookieTempDataProviderOptions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Name) + ".")]
        public string CookieName { get; set; } = CookieTempDataProvider.CookieName;
        #endregion

(43) src\Components\Components\src\Json\JsonUtil.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("Use Microsoft.JSInterop.Json instead.")]
    public static class JsonUtil
    {

(44) src\Components\Components\src\Json\JsonUtil.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("Use Microsoft.JSInterop.Json.Serialize instead.")]
        public static string Serialize(object value)
            => Json.Serialize(value);

(45) src\Components\Components\src\Json\JsonUtil.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("Use Microsoft.JSInterop.Json.Deserialize<T> instead.")]
        public static T Deserialize<T>(string json)
            => Json.Deserialize<T>(json);

(46) src\Http\Routing\src\Tree\TreeRouteBuilder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended " +
            "alternative is the overload that does not take a UrlEncoder.")]
        public TreeRouteBuilder(

(47) src\Middleware\CORS\src\Infrastructure\CorsService.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public CorsService(IOptions<CorsOptions> options)
            : this(options, loggerFactory: NullLoggerFactory.Instance)

(48) src\Mvc\src\Microsoft.AspNetCore.Mvc.Abstractions\Formatters\OutputFormatterCanWriteContext.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. Please use the constructor taking a HttpContext instead.")]
        protected OutputFormatterCanWriteContext()
        {

(49) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\Formatters\FormatFilter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public FormatFilter(IOptions<MvcOptions> options)
            : this(options, NullLoggerFactory.Instance)

(50) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\ModelBinderFactory.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(IServiceProvider) + ".")]
        public ModelBinderFactory(IModelMetadataProvider metadataProvider, IOptions<MvcOptions> options)

(51) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\ParameterBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes a " + nameof(MvcOptions) + " accessor and an "
            + nameof(ILoggerFactory) + " .")]

(52) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\ParameterBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This method overload is obsolete and will be removed in a future version. The recommended " +
            "alternative is the overload that also takes " + nameof(IModelBinder) + ", " + nameof(ModelMetadata) +
            " and " + nameof(Object) + " parameters.")]

(53) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\ParameterBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This method overload is obsolete and will be removed in a future version. The recommended " +
            "alternative is the overload that also takes " + nameof(IModelBinder) + " and " + nameof(ModelMetadata) +
            " parameters.")]

(54) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\Routing\KnownRouteValueConstraint.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete. Use KnownRouteValueConstraint.ctor(IActionDescriptorCollectionProvider) instead.")]
        public KnownRouteValueConstraint()
        {

(55) src\Mvc\src\Microsoft.AspNetCore.Mvc.Razor\Compilation\CompiledViewDescriptor.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("Use Item instead. RazorViewAttribute has been superseded by RazorCompiledItem and will not be used by the runtime.")]
        public RazorViewAttribute ViewAttribute { get; set; }
#pragma warning restore CS0618 // Type or member is obsolete

(56) src\Mvc\src\Microsoft.AspNetCore.Mvc.Razor\Compilation\RazorViewAttribute.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This attribute has been superseded by RazorCompiledItem and will not be used by the runtime.")]
    [AttributeUsage(AttributeTargets.Assembly, AllowMultiple = true)]
    public class RazorViewAttribute : Attribute

(57) src\Mvc\src\Microsoft.AspNetCore.Mvc.Razor\Compilation\ViewsFeatureProvider.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is obsolete and will be removed in a future version. See " + nameof(IRazorCompiledItemProvider) + " for alternatives.")]
    public class ViewsFeatureProvider : IApplicationFeatureProvider<ViewsFeature>
    {

(58) src\Mvc\src\Microsoft.AspNetCore.Mvc.RazorPages\Infrastructure\PageArgumentBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is obsolete and will be removed in a future version.")]
    public abstract class PageArgumentBinder
    {

(59) src\Mvc\src\Microsoft.AspNetCore.Mvc.RazorPages\Infrastructure\RazorPageAdapter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public RazorPageAdapter(RazorPageBase page)
        {

(60) src\Mvc\src\Microsoft.AspNetCore.Mvc.RazorPages\Infrastructure\RazorPageAttribute.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This attribute has been superseded by RazorCompiledItem and will not be used by the runtime.")]
    public class RazorPageAttribute : RazorViewAttribute
    {

(61) src\Security\Authentication\Cookies\src\CookieAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseCookieAuthentication is obsolete. Configure Cookie authentication with AddAuthentication().AddCookie in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseCookieAuthentication(this IApplicationBuilder app)
        {

(62) src\Security\Authentication\Cookies\src\CookieAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseCookieAuthentication is obsolete. Configure Cookie authentication with AddAuthentication().AddCookie in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseCookieAuthentication(this IApplicationBuilder app, CookieAuthenticationOptions options)
        {

(63) src\Security\Authentication\Facebook\src\FacebookAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseFacebookAuthentication is obsolete. Configure Facebook authentication with AddAuthentication().AddFacebook in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseFacebookAuthentication(this IApplicationBuilder app)
        {

(64) src\Security\Authentication\Facebook\src\FacebookAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseFacebookAuthentication is obsolete. Configure Facebook authentication with AddAuthentication().AddFacebook in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseFacebookAuthentication(this IApplicationBuilder app, FacebookOptions options)
        {

(65) src\Security\Authentication\Google\src\GoogleAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseGoogleAuthentication is obsolete. Configure Google authentication with AddAuthentication().AddGoogle in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseGoogleAuthentication(this IApplicationBuilder app)
        {

(66) src\Security\Authentication\Google\src\GoogleAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseGoogleAuthentication is obsolete. Configure Google authentication with AddAuthentication().AddGoogle in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseGoogleAuthentication(this IApplicationBuilder app, GoogleOptions options)
        {

(67) src\Security\Authentication\JwtBearer\src\JwtBearerAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseJwtBearerAuthentication is obsolete. Configure JwtBearer authentication with AddAuthentication().AddJwtBearer in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseJwtBearerAuthentication(this IApplicationBuilder app)
        {

(68) src\Security\Authentication\JwtBearer\src\JwtBearerAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseJwtBearerAuthentication is obsolete. Configure JwtBearer authentication with AddAuthentication().AddJwtBearer in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseJwtBearerAuthentication(this IApplicationBuilder app, JwtBearerOptions options)
        {

(69) src\Security\Authentication\MicrosoftAccount\src\MicrosoftAccountAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseMicrosoftAccountAuthentication is obsolete. Configure MicrosoftAccount authentication with AddAuthentication().AddMicrosoftAccount in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseMicrosoftAccountAuthentication(this IApplicationBuilder app)
        {

(70) src\Security\Authentication\MicrosoftAccount\src\MicrosoftAccountAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseMicrosoftAccountAuthentication is obsolete. Configure MicrosoftAccount authentication with AddAuthentication().AddMicrosoftAccount in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseMicrosoftAccountAuthentication(this IApplicationBuilder app, MicrosoftAccountOptions options)
        {

(71) src\Security\Authentication\OAuth\src\OAuthAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseOAuthAuthentication is obsolete. Configure OAuth authentication with AddAuthentication().AddOAuth in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseOAuthAuthentication(this IApplicationBuilder app)
        {

(72) src\Security\Authentication\OAuth\src\OAuthAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseOAuthAuthentication is obsolete. Configure OAuth authentication with AddAuthentication().AddOAuth in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseOAuthAuthentication(this IApplicationBuilder app, OAuthOptions options)
        {

(73) src\Security\Authentication\OpenIdConnect\src\OpenIdConnectAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseOpenIdConnectAuthentication is obsolete. Configure OpenIdConnect authentication with AddAuthentication().AddOpenIdConnect in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseOpenIdConnectAuthentication(this IApplicationBuilder app)
        {

(74) src\Security\Authentication\OpenIdConnect\src\OpenIdConnectAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseOpenIdConnectAuthentication is obsolete. Configure OpenIdConnect authentication with AddAuthentication().AddOpenIdConnect in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseOpenIdConnectAuthentication(this IApplicationBuilder app, OpenIdConnectOptions options)
        {

(75) src\Security\Authentication\Twitter\src\TwitterAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseTwitterAuthentication is obsolete. Configure Twitter authentication with AddAuthentication().AddTwitter in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseTwitterAuthentication(this IApplicationBuilder app)
        {

(76) src\Security\Authentication\Twitter\src\TwitterAppBuilderExtensions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("UseTwitterAuthentication is obsolete. Configure Twitter authentication with AddAuthentication().AddTwitter in ConfigureServices. See https://go.microsoft.com/fwlink/?linkid=845470 for more details.", error: true)]
        public static IApplicationBuilder UseTwitterAuthentication(this IApplicationBuilder app, TwitterOptions options)
        {

(77) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\ArrayModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public ArrayModelBinder(IModelBinder elementBinder)

(78) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\ByteArrayModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that takes an " + nameof(ILoggerFactory) + ".")]
        public ByteArrayModelBinder()

(79) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\CollectionModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public CollectionModelBinder(IModelBinder elementBinder)

(80) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\ComplexTypeModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public ComplexTypeModelBinder(IDictionary<ModelMetadata, IModelBinder> propertyBinders)

(81) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\DecimalModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public DecimalModelBinder(NumberStyles supportedStyles)

(82) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\DictionaryModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public DictionaryModelBinder(IModelBinder keyBinder, IModelBinder valueBinder)

(83) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\DoubleModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public DoubleModelBinder(NumberStyles supportedStyles)

(84) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\FloatModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public FloatModelBinder(NumberStyles supportedStyles)

(85) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\FormCollectionModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that takes an " + nameof(ILoggerFactory) + ".")]
        public FormCollectionModelBinder()

(86) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\FormFileModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that takes an " + nameof(ILoggerFactory) + ".")]
        public FormFileModelBinder()

(87) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\HeaderModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that takes an " + nameof(ILoggerFactory) + " and an " + nameof(IModelBinder) + ".")]
        public HeaderModelBinder()

(88) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\KeyValuePairModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public KeyValuePairModelBinder(IModelBinder keyBinder, IModelBinder valueBinder)

(89) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\SimpleTypeModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public SimpleTypeModelBinder(Type type)

(90) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Metadata\ModelAttributes.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative is " + nameof(ModelAttributes) + "." + nameof(GetAttributesForType) + ".")]
        public ModelAttributes(IEnumerable<object> typeAttributes)
            : this(typeAttributes, null, null)

(91) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Metadata\ModelAttributes.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative is " + nameof(ModelAttributes) + "." + nameof(GetAttributesForProperty) + ".")]
        public ModelAttributes(IEnumerable<object> propertyAttributes, IEnumerable<object> typeAttributes)
            : this(typeAttributes, propertyAttributes, null)

(92) src\Middleware\Diagnostics\src\WelcomePage\Views\Obsolete\WelcomePage.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is for internal use only and will be removed in a future version.")]
    public class WelcomePage : Microsoft.AspNetCore.DiagnosticsViewPage.Views.BaseView
    {

@Eilon Eilon assigned muratg, mkArtakMSFT and ajcvickers and unassigned Eilon Jan 30, 2019
@Eilon
Copy link
Contributor

Eilon commented Jan 30, 2019

@mkArtakMSFT / @muratg / @ajcvickers - please review the list above and take appropriate action on the items.

@Eilon Eilon changed the title Consider removing all Obsolete APIs when we start working on 3.0.0 Evaluate obsolete APIs from 2.2 and consider removing them in 3.0.0 Jan 30, 2019
@muratg
Copy link
Contributor

muratg commented Jan 30, 2019

@Eilon I reacted to 3 of the items that are in my areas, and filed bugs for them. (Nice work BTW!)

@Eilon Eilon unassigned muratg Feb 6, 2019
This was referenced Feb 6, 2019
Closed
Closed
Closed
Closed
This was referenced Feb 6, 2019
Closed
Closed
Closed
@Eilon Eilon assigned Eilon and unassigned ajcvickers and mkArtakMSFT Mar 21, 2019
@Eilon
Copy link
Contributor

Eilon commented Mar 21, 2019

Need to check again in the release/2.2 branch and see what's left.

@Eilon
Copy link
Contributor

Eilon commented Apr 17, 2019

I reviewed all current master Obsolete attributes in our product code repos (EF, AspNetCore, Tooling, and Extensions) and none are remnants from 2.2 So, we're good to go for 3.0!

@Eilon Eilon closed this as completed Apr 17, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Eilon Eilon

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework breaking-change This issue / pr will introduce a breaking change, when resolved / merged.
Projects
None yet
Milestone
3.0.0-preview4
Development

No branches or pull requests
8 participants
@Eilon @rynowak @ajcvickers @muratg @natemcmaster @dougbu @mkArtakMSFT @aspnet-hello