Skip to content

Remove obsolete APIs from MVC #7322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 of 50 tasks
mkArtakMSFT opened this issue Feb 6, 2019 · 1 comment
Closed
3 of 50 tasks

Remove obsolete APIs from MVC #7322

mkArtakMSFT opened this issue Feb 6, 2019 · 1 comment
Assignees
@pranavkm
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates breaking-change This issue / pr will introduce a breaking change, when resolved / merged. bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview3

Comments

@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Feb 6, 2019 •
edited by pranavkm
Loading

See #3654 for details.

(15) src\Mvc\src\Microsoft.AspNetCore.Mvc.ApiExplorer\DefaultApiDescriptionProvider.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future release.")]
        public DefaultApiDescriptionProvider(
            IOptions<MvcOptions> optionsAccessor,

(16) src\Mvc\src\Microsoft.AspNetCore.Mvc.ApiExplorer\DefaultApiDescriptionProvider.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future release.")]
        public DefaultApiDescriptionProvider(
            IOptions<MvcOptions> optionsAccessor,

(17) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\CompatibilityVersion.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This " + nameof(CompatibilityVersion) + " value is obsolete. The recommended alternatives are " +
            nameof(Version_3_0) + " or later.")]
        Version_2_0,

(18) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\CompatibilityVersion.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This " + nameof(CompatibilityVersion) + " value is obsolete. The recommended alternatives are " +
            nameof(Version_3_0) + " or later.")]
        Version_2_1,

(19) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\CompatibilityVersion.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This " + nameof(CompatibilityVersion) + " value is obsolete. The recommended alternatives are " +
            nameof(Version_3_0) + " or later.")]
        Version_2_2,

(20) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\LocalRedirectResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
        public override void ExecuteResult(ActionContext context)
        {

(21) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\RedirectResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
        public override void ExecuteResult(ActionContext context)
        {

(22) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\RedirectToActionResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
        public override void ExecuteResult(ActionContext context)
        {

(23) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\RedirectToPageResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
        public override void ExecuteResult(ActionContext context)
        {

(24) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\RedirectToRouteResult.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
        public override void ExecuteResult(ActionContext context)
        {

(25) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\ProblemDetails21Wrapper.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is deprecated and will be removed in a future version")]
    public class ProblemDetails21Wrapper : IXmlSerializable, IUnwrappable
    {

(26) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\ValidationProblemDetails21Wrapper.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is deprecated and will be removed in a future version")]
    public class ValidationProblemDetails21Wrapper : ProblemDetails21Wrapper, IUnwrappable
    {

(27) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\XmlDataContractSerializerInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public XmlDataContractSerializerInputFormatter()
        {

(28) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\XmlDataContractSerializerInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public XmlDataContractSerializerInputFormatter(bool suppressInputFormatterBuffering)
            : this()

(29) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\XmlSerializerInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public XmlSerializerInputFormatter()
        {

(30) src\Mvc\src\Microsoft.AspNetCore.Mvc.Formatters.Xml\XmlSerializerInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public XmlSerializerInputFormatter(bool suppressInputFormatterBuffering)
            : this()

(31) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonInputFormatter(
            ILogger logger,

(32) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonInputFormatter(
            ILogger logger,

(33) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonInputFormatter(
            ILogger logger,

(34) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonPatchInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonPatchInputFormatter(
            ILogger logger,

(35) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonPatchInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonPatchInputFormatter(
            ILogger logger,

(36) src\Mvc\src\Microsoft.AspNetCore.Mvc.NewtonsoftJson\NewtonsoftJsonPatchInputFormatter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public NewtonsoftJsonPatchInputFormatter(
            ILogger logger,

(37) src\Mvc\src\Microsoft.AspNetCore.Mvc.TagHelpers\ImageTagHelper.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public ImageTagHelper(
            IHostingEnvironment hostingEnvironment,

(38) src\Mvc\src\Microsoft.AspNetCore.Mvc.TagHelpers\LinkTagHelper.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public LinkTagHelper(
            IHostingEnvironment hostingEnvironment,

(39) src\Mvc\src\Microsoft.AspNetCore.Mvc.TagHelpers\ScriptTagHelper.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public ScriptTagHelper(
            IHostingEnvironment hostingEnvironment,

(40) src\Mvc\src\Microsoft.AspNetCore.Mvc.ViewFeatures\CookieTempDataProviderOptions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Path) + ".")]
        public string Path { get => Cookie.Path; set => Cookie.Path = value; }

(41) src\Mvc\src\Microsoft.AspNetCore.Mvc.ViewFeatures\CookieTempDataProviderOptions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Domain) + ".")]
        public string Domain { get => Cookie.Domain; set => Cookie.Domain = value; }

(42) src\Mvc\src\Microsoft.AspNetCore.Mvc.ViewFeatures\CookieTempDataProviderOptions.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Name) + ".")]
        public string CookieName { get; set; } = CookieTempDataProvider.CookieName;
        #endregion

(48) src\Mvc\src\Microsoft.AspNetCore.Mvc.Abstractions\Formatters\OutputFormatterCanWriteContext.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. Please use the constructor taking a HttpContext instead.")]
        protected OutputFormatterCanWriteContext()
        {

(49) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\Formatters\FormatFilter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public FormatFilter(IOptions<MvcOptions> options)
            : this(options, NullLoggerFactory.Instance)

(50) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\ModelBinderFactory.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(IServiceProvider) + ".")]
        public ModelBinderFactory(IModelMetadataProvider metadataProvider, IOptions<MvcOptions> options)

(51) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\ParameterBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes a " + nameof(MvcOptions) + " accessor and an "
            + nameof(ILoggerFactory) + " .")]

(52) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\ParameterBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This method overload is obsolete and will be removed in a future version. The recommended " +
            "alternative is the overload that also takes " + nameof(IModelBinder) + ", " + nameof(ModelMetadata) +
            " and " + nameof(Object) + " parameters.")]

(53) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\ParameterBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This method overload is obsolete and will be removed in a future version. The recommended " +
            "alternative is the overload that also takes " + nameof(IModelBinder) + " and " + nameof(ModelMetadata) +
            " parameters.")]

(54) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\Routing\KnownRouteValueConstraint.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete. Use KnownRouteValueConstraint.ctor(IActionDescriptorCollectionProvider) instead.")]
        public KnownRouteValueConstraint()
        {

(77) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\ArrayModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public ArrayModelBinder(IModelBinder elementBinder)

(78) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\ByteArrayModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that takes an " + nameof(ILoggerFactory) + ".")]
        public ByteArrayModelBinder()

(79) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\CollectionModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public CollectionModelBinder(IModelBinder elementBinder)

(80) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\ComplexTypeModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public ComplexTypeModelBinder(IDictionary<ModelMetadata, IModelBinder> propertyBinders)

(81) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\DecimalModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public DecimalModelBinder(NumberStyles supportedStyles)

(82) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\DictionaryModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public DictionaryModelBinder(IModelBinder keyBinder, IModelBinder valueBinder)

(83) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\DoubleModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public DoubleModelBinder(NumberStyles supportedStyles)

(84) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\FloatModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public FloatModelBinder(NumberStyles supportedStyles)

(85) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\FormCollectionModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that takes an " + nameof(ILoggerFactory) + ".")]
        public FormCollectionModelBinder()

(86) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\FormFileModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that takes an " + nameof(ILoggerFactory) + ".")]
        public FormFileModelBinder()

(87) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\HeaderModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that takes an " + nameof(ILoggerFactory) + " and an " + nameof(IModelBinder) + ".")]
        public HeaderModelBinder()

(88) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\KeyValuePairModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public KeyValuePairModelBinder(IModelBinder keyBinder, IModelBinder valueBinder)

(89) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Binders\SimpleTypeModelBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
        public SimpleTypeModelBinder(Type type)

(90) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Metadata\ModelAttributes.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative is " + nameof(ModelAttributes) + "." + nameof(GetAttributesForType) + ".")]
        public ModelAttributes(IEnumerable<object> typeAttributes)
            : this(typeAttributes, null, null)

(91) src\Mvc\src\Microsoft.AspNetCore.Mvc.Core\ModelBinding\Metadata\ModelAttributes.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative is " + nameof(ModelAttributes) + "." + nameof(GetAttributesForProperty) + ".")]
        public ModelAttributes(IEnumerable<object> propertyAttributes, IEnumerable<object> typeAttributes)
            : this(typeAttributes, propertyAttributes, null)
@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. 1 - Ready area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Feb 6, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview3 milestone Feb 6, 2019
@mkArtakMSFT mkArtakMSFT added the breaking-change This issue / pr will introduce a breaking change, when resolved / merged. label Feb 6, 2019
pranavkm added a commit that referenced this issue Feb 11, 2019
@pranavkm
Remove obsolete APIs from MVC
72c74e3 
Fixes #7322
@pranavkm pranavkm mentioned this issue Feb 11, 2019
Merged
pranavkm added a commit that referenced this issue Feb 11, 2019
@pranavkm
Remove obsolete APIs from MVC
e979abd 
Fixes #7322
pranavkm added a commit that referenced this issue Feb 11, 2019
@pranavkm
Remove obsolete APIs from MVC (#7444)
88ae930 
* Remove obsolete APIs from MVC
Fixes #7322
@pranavkm pranavkm added Done This issue has been fixed and removed 1 - Ready labels Feb 11, 2019
@pranavkm
Copy link
Contributor

All of the above minus the obsolete CompatibilityVersion enum values are done as part of 88ae930

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates breaking-change This issue / pr will introduce a breaking change, when resolved / merged. bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview3
Development

No branches or pull requests
2 participants
@pranavkm @mkArtakMSFT