Remove obsolete APIs from MVC

Fixes #7322

Author: pranavkm

src/Mvc/src/Microsoft.AspNetCore.Mvc.Abstractions/Formatters/OutputFormatterCanWriteContext.cs

@@ -12,20 +12,6 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
     /// </summary>
     public abstract class OutputFormatterCanWriteContext
     {
-        /// <summary>
-        /// <para>
-        /// This constructor is obsolete and will be removed in a future version.
-        /// Please use <see cref="OutputFormatterCanWriteContext(Http.HttpContext)"/> instead.
-        /// </para>
-        /// <para>
-        /// Creates a new <see cref="OutputFormatterCanWriteContext"/>.
-        /// </para>
-        /// </summary>
-        [Obsolete("This constructor is obsolete and will be removed in a future version. Please use the constructor taking a HttpContext instead.")]
-        protected OutputFormatterCanWriteContext()
-        {
-        }
-
         /// <summary>
         /// Creates a new <see cref="OutputFormatterCanWriteContext"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.ApiExplorer/DefaultApiDescriptionProvider.cs

@@ -29,44 +29,6 @@ public class DefaultApiDescriptionProvider : IApiDescriptionProvider
         private readonly IInlineConstraintResolver _constraintResolver;
         private readonly IModelMetadataProvider _modelMetadataProvider;
 
-        /// <summary>
-        /// Creates a new instance of <see cref="DefaultApiDescriptionProvider"/>.
-        /// </summary>
-        /// <param name="optionsAccessor">The accessor for <see cref="MvcOptions"/>.</param>
-        /// <param name="constraintResolver">The <see cref="IInlineConstraintResolver"/> used for resolving inline
-        /// constraints.</param>
-        /// <param name="modelMetadataProvider">The <see cref="IModelMetadataProvider"/>.</param>
-        [Obsolete("This constructor is obsolete and will be removed in a future release.")]
-        public DefaultApiDescriptionProvider(
-            IOptions<MvcOptions> optionsAccessor,
-            IInlineConstraintResolver constraintResolver,
-            IModelMetadataProvider modelMetadataProvider)
-            : this(optionsAccessor, constraintResolver, modelMetadataProvider, null)
-        {
-        }
-
-        /// <summary>
-        /// Creates a new instance of <see cref="DefaultApiDescriptionProvider"/>.
-        /// </summary>
-        /// <param name="optionsAccessor">The accessor for <see cref="MvcOptions"/>.</param>
-        /// <param name="constraintResolver">The <see cref="IInlineConstraintResolver"/> used for resolving inline
-        /// constraints.</param>
-        /// <param name="modelMetadataProvider">The <see cref="IModelMetadataProvider"/>.</param>
-        /// <param name="mapper">The <see cref="IActionResultTypeMapper"/>.</param>
-        /// <remarks>The <paramref name="mapper"/> parameter is currently ignored.</remarks>
-        [Obsolete("This constructor is obsolete and will be removed in a future release.")]
-        public DefaultApiDescriptionProvider(
-            IOptions<MvcOptions> optionsAccessor,
-            IInlineConstraintResolver constraintResolver,
-            IModelMetadataProvider modelMetadataProvider,
-            IActionResultTypeMapper mapper)
-        {
-            _mvcOptions = optionsAccessor.Value;
-            _constraintResolver = constraintResolver;
-            _modelMetadataProvider = modelMetadataProvider;
-            _responseTypeProvider = new ApiResponseTypeProvider(modelMetadataProvider, mapper, _mvcOptions);
-        }
-
         /// <summary>
         /// Creates a new instance of <see cref="DefaultApiDescriptionProvider"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/Formatters/FormatFilter.cs

@@ -21,16 +21,6 @@ public class FormatFilter : IFormatFilter, IResourceFilter, IResultFilter
         private readonly MvcOptions _options;
         private readonly ILogger _logger;
 
-        /// <summary>
-        /// Initializes an instance of <see cref="FormatFilter"/>.
-        /// </summary>
-        /// <param name="options">The <see cref="IOptions{MvcOptions}"/></param>
-        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
-        public FormatFilter(IOptions<MvcOptions> options)
-            : this(options, NullLoggerFactory.Instance)
-        {
-        }
-
         /// <summary>
         /// Initializes an instance of <see cref="FormatFilter"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/LocalRedirectResult.cs

@@ -104,42 +104,5 @@ public override Task ExecuteResultAsync(ActionContext context)
             var executor = context.HttpContext.RequestServices.GetRequiredService<IActionResultExecutor<LocalRedirectResult>>();
             return executor.ExecuteAsync(context, this);
         }
-
-#pragma warning disable CS0809
-        [Obsolete("This implementation will be removed in a future release, use ExecuteResultAsync.")]
-        public override void ExecuteResult(ActionContext context)
-        {
-            if (context == null)
-            {
-                throw new ArgumentNullException(nameof(context));
-            }
-
-            var services = context.HttpContext.RequestServices;
-            var urlHelperFactory = services.GetRequiredService<IUrlHelperFactory>();
-            var logger = services.GetRequiredService<ILogger<LocalRedirectResult>>();
-
-            var urlHelper = UrlHelper ?? urlHelperFactory.GetUrlHelper(context);
-
-            // IsLocalUrl is called to handle  Urls starting with '~/'.
-            if (!urlHelper.IsLocalUrl(Url))
-            {
-                throw new InvalidOperationException(Resources.UrlNotLocal);
-            }
-
-            var destinationUrl = urlHelper.Content(Url);
-            logger.LocalRedirectResultExecuting(destinationUrl);
-
-            if (PreserveMethod)
-            {
-                context.HttpContext.Response.StatusCode = Permanent ?
-                    StatusCodes.Status308PermanentRedirect : StatusCodes.Status307TemporaryRedirect;
-                context.HttpContext.Response.Headers[HeaderNames.Location] = destinationUrl;
-            }
-            else
-            {
-                context.HttpContext.Response.Redirect(destinationUrl, Permanent);
-            }
-        }
-#pragma warning restore CS0809
     }
 }

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/ArrayModelBinder.cs

@@ -6,7 +6,6 @@
 using System.Diagnostics;
 using System.Linq;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 
 namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
 {
@@ -16,21 +15,6 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
     /// <typeparam name="TElement">Type of elements in the array.</typeparam>
     public class ArrayModelBinder<TElement> : CollectionModelBinder<TElement>
     {
-        /// <summary>
-        /// <para>This constructor is obsolete and will be removed in a future version. The recommended alternative
-        /// is the overload that also takes an <see cref="ILoggerFactory"/>.</para>
-        /// <para>Creates a new <see cref="ArrayModelBinder{TElement}"/>.</para>
-        /// </summary>
-        /// <param name="elementBinder">
-        /// The <see cref="IModelBinder"/> for binding <typeparamref name="TElement"/>.
-        /// </param>
-        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
-            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
-        public ArrayModelBinder(IModelBinder elementBinder)
-            : this(elementBinder, NullLoggerFactory.Instance)
-        {
-        }
-
         /// <summary>
         /// Creates a new <see cref="ArrayModelBinder{TElement}"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/ByteArrayModelBinder.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Threading.Tasks;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 
 namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
 {
@@ -15,18 +14,6 @@ public class ByteArrayModelBinder : IModelBinder
     {
         private readonly ILogger _logger;
 
-        /// <summary>
-        /// <para>This constructor is obsolete and will be removed in a future version. The recommended alternative
-        /// is the overload that takes an <see cref="ILoggerFactory"/>.</para>
-        /// <para>Initializes a new instance of <see cref="ByteArrayModelBinder"/>.</para>
-        /// </summary>
-        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
-            + " is the overload that takes an " + nameof(ILoggerFactory) + ".")]
-        public ByteArrayModelBinder()
-            : this(NullLoggerFactory.Instance)
-        {
-        }
-
         /// <summary>
         /// Initializes a new instance of <see cref="ByteArrayModelBinder"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/CollectionModelBinder.cs

@@ -11,7 +11,6 @@
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Mvc.ModelBinding.Validation;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 
 namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
 {
@@ -24,19 +23,6 @@ public class CollectionModelBinder<TElement> : ICollectionModelBinder
         private static readonly IValueProvider EmptyValueProvider = new CompositeValueProvider();
         private Func<object> _modelCreator;
 
-        /// <summary>
-        /// <para>This constructor is obsolete and will be removed in a future version. The recommended alternative
-        /// is the overload that also takes an <see cref="ILoggerFactory"/>.</para>
-        /// <para>Creates a new <see cref="CollectionModelBinder{TElement}"/>.</para>
-        /// </summary>
-        /// <param name="elementBinder">The <see cref="IModelBinder"/> for binding elements.</param>
-        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
-            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
-        public CollectionModelBinder(IModelBinder elementBinder)
-            : this(elementBinder, NullLoggerFactory.Instance)
-        {
-        }
-
         /// <summary>
         /// Creates a new <see cref="CollectionModelBinder{TElement}"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/ComplexTypeModelBinder.cs

@@ -9,7 +9,6 @@
 using Microsoft.AspNetCore.Mvc.Core;
 using Microsoft.AspNetCore.Mvc.ModelBinding.Metadata;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 
 namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
 {
@@ -22,21 +21,6 @@ public class ComplexTypeModelBinder : IModelBinder
         private readonly ILogger _logger;
         private Func<object> _modelCreator;
 
-        /// <summary>
-        /// <para>This constructor is obsolete and will be removed in a future version. The recommended alternative
-        /// is the overload that also takes an <see cref="ILoggerFactory"/>.</para>
-        /// <para>Creates a new <see cref="ComplexTypeModelBinder"/>.</para>
-        /// </summary>
-        /// <param name="propertyBinders">
-        /// The <see cref="IDictionary{TKey, TValue}"/> of binders to use for binding properties.
-        /// </param>
-        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
-            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
-        public ComplexTypeModelBinder(IDictionary<ModelMetadata, IModelBinder> propertyBinders)
-            : this(propertyBinders, NullLoggerFactory.Instance)
-        {
-        }
-
         /// <summary>
         /// Creates a new <see cref="ComplexTypeModelBinder"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/DecimalModelBinder.cs

@@ -6,7 +6,6 @@
 using System.Runtime.ExceptionServices;
 using System.Threading.Tasks;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 
 namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
 {
@@ -19,19 +18,6 @@ public class DecimalModelBinder : IModelBinder
         private readonly NumberStyles _supportedStyles;
         private readonly ILogger _logger;
 
-        /// <summary>
-        /// <para>This constructor is obsolete and will be removed in a future version. The recommended alternative
-        /// is the overload that also takes an <see cref="ILoggerFactory"/>.</para>
-        /// <para>Initializes a new instance of <see cref="DecimalModelBinder"/>.</para>
-        /// </summary>
-        /// <param name="supportedStyles">The <see cref="NumberStyles"/>.</param>
-        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
-            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
-        public DecimalModelBinder(NumberStyles supportedStyles)
-            : this(supportedStyles, NullLoggerFactory.Instance)
-        {
-        }
-
         /// <summary>
         /// Initializes a new instance of <see cref="DecimalModelBinder"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/DictionaryModelBinder.cs

@@ -8,7 +8,6 @@
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Mvc.ModelBinding.Validation;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 
 namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
 {
@@ -21,20 +20,6 @@ public class DictionaryModelBinder<TKey, TValue> : CollectionModelBinder<KeyValu
     {
         private readonly IModelBinder _valueBinder;
 
-        /// <summary>
-        /// <para>This constructor is obsolete and will be removed in a future version. The recommended alternative
-        /// is the overload that also takes an <see cref="ILoggerFactory"/>.</para>
-        /// <para>Creates a new <see cref="DictionaryModelBinder{TKey, TValue}"/>.</para>
-        /// </summary>
-        /// <param name="keyBinder">The <see cref="IModelBinder"/> for <typeparamref name="TKey"/>.</param>
-        /// <param name="valueBinder">The <see cref="IModelBinder"/> for <typeparamref name="TValue"/>.</param>
-        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
-            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
-        public DictionaryModelBinder(IModelBinder keyBinder, IModelBinder valueBinder)
-            : this(keyBinder, valueBinder, NullLoggerFactory.Instance)
-        {
-        }
-
         /// <summary>
         /// Creates a new <see cref="DictionaryModelBinder{TKey, TValue}"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/DoubleModelBinder.cs

@@ -6,7 +6,6 @@
 using System.Runtime.ExceptionServices;
 using System.Threading.Tasks;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 
 namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
 {
@@ -19,19 +18,6 @@ public class DoubleModelBinder : IModelBinder
         private readonly NumberStyles _supportedStyles;
         private readonly ILogger _logger;
 
-        /// <summary>
-        /// <para>This constructor is obsolete and will be removed in a future version. The recommended alternative
-        /// is the overload that also takes an <see cref="ILoggerFactory"/>.</para>
-        /// <para>Initializes a new instance of <see cref="DoubleModelBinder"/>.</para>
-        /// </summary>
-        /// <param name="supportedStyles">The <see cref="NumberStyles"/>.</param>
-        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
-            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
-        public DoubleModelBinder(NumberStyles supportedStyles)
-            : this(supportedStyles, NullLoggerFactory.Instance)
-        {
-        }
-
         /// <summary>
         /// Initializes a new instance of <see cref="DoubleModelBinder"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/FloatModelBinder.cs

@@ -6,7 +6,6 @@
 using System.Runtime.ExceptionServices;
 using System.Threading.Tasks;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 
 namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
 {
@@ -19,19 +18,6 @@ public class FloatModelBinder : IModelBinder
         private readonly NumberStyles _supportedStyles;
         private readonly ILogger _logger;
 
-        /// <summary>
-        /// <para>This constructor is obsolete and will be removed in a future version. The recommended alternative
-        /// is the overload that also takes an <see cref="ILoggerFactory"/>.</para>
-        /// <para>Initializes a new instance of <see cref="FloatModelBinder"/>.</para>
-        /// </summary>
-        /// <param name="supportedStyles">The <see cref="NumberStyles"/>.</param>
-        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
-            + " is the overload that also takes an " + nameof(ILoggerFactory) + ".")]
-        public FloatModelBinder(NumberStyles supportedStyles)
-            : this(supportedStyles, NullLoggerFactory.Instance)
-        {
-        }
-
         /// <summary>
         /// Initializes a new instance of <see cref="FloatModelBinder"/>.
         /// </summary>

src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/FormCollectionModelBinder.cs

@@ -8,7 +8,6 @@
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 using Microsoft.Extensions.Primitives;
 
 namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
@@ -20,18 +19,6 @@ public class FormCollectionModelBinder : IModelBinder
     {
         private readonly ILogger _logger;
 
-        /// <summary>
-        /// <para>This constructor is obsolete and will be removed in a future version. The recommended alternative
-        /// is the overload that takes an <see cref="ILoggerFactory"/>.</para>
-        /// <para>Initializes a new instance of <see cref="FormCollectionModelBinder"/>.</para>
-        /// </summary>
-        [Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative"
-            + " is the overload that takes an " + nameof(ILoggerFactory) + ".")]
-        public FormCollectionModelBinder()
-            : this(NullLoggerFactory.Instance)
-        {
-        }
-
         /// <summary>
         /// Initializes a new instance of <see cref="FormCollectionModelBinder"/>.
         /// </summary>