Remove obsolete APIs from MVC #7444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
approved these changes
Feb 11, 2019
There was a problem hiding this comment.
Looks very straightforward
- Note [MVC] Remove obsolete APIs #7374 removes some of the same classes e.g.
PageArgumentBinder - Neither PR handles
[Obsolete]members inImageTagHelper,LinkTagHelperorScriptTagHelper- When is that cleanup coming?
src/Mvc/test/Microsoft.AspNetCore.Mvc.Core.Test/Routing/KnownRouteValueConstraintTests.cs
Outdated
Show resolved
Hide resolved
rynowak
approved these changes
Feb 11, 2019
pranavkm
force-pushed
the
prkrishn/obsolete2
branch
from
7040f5a to
74cfe3e
Compare
|
@dougbu removed the *TagHelper ones. I assumed the other PR would have addressed it. |
Eilon
added
the
area-mvc
pranavkm
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7322