[MVC] Remove obsolete APIs #7374
Conversation
NTaylorMullen
requested review from
pranavkm,
rynowak,
ajaybhargavb and
dougbu
src/Mvc/src/Microsoft.AspNetCore.Mvc.Razor/Compilation/CompiledViewDescriptor.cs
Outdated
Show resolved
Hide resolved
src/Mvc/src/Microsoft.AspNetCore.Mvc.Razor/Compilation/RazorViewAttribute.cs
Outdated
Show resolved
Hide resolved
| /// An <see cref="IApplicationFeatureProvider{TFeature}"/> for <see cref="ViewsFeature"/>. | ||
| /// </summary> | ||
| [Obsolete("This type is obsolete and will be removed in a future version. See " + nameof(IRazorCompiledItemProvider) + " for alternatives.")] | ||
| public class ViewsFeatureProvider : IApplicationFeatureProvider<ViewsFeature> |
There was a problem hiding this comment.
For contrast, this is random old extensibility that is a good thing to remove since it will rarely appear in user-code.
There was a problem hiding this comment.
One concern I do have, is if I remove this but don't remove the RazorViewAttribute and a user doesn't heed the obsolete warnings they'll get a hard to resolve, significant behavior change.
There was a problem hiding this comment.
and a user doesn't heed the obsolete warnings they'll get a hard to resolve
We can add it to the migration notes as something to be aware of. If we get lots of user feedback (I'd think it's fairly unlikely given this attribute comes from Precompilation), we can always change the runtime to throw.
There was a problem hiding this comment.
I'm still not convinced since i'd rather break hard or not at all then break soft when it comes to these things (can have migration guidance with either hard or soft breaks). I'll leave it as removed though since you both feel differently 😄
@danroth27 is there a place where we're collecting migration guidance?
Eilon
added
the
area-mvc
NTaylorMullen
force-pushed
the
nimullen/7326
branch
from
ccf7d64 to
a452cf6
Compare
|
🆙 📅 |
- Removed ViewsFeatureProvider - Removed PageArgumentBinder and its internal implementation DefaultPageArgumentBinder. - Removed corresponding test classes/methods for all the above. - Reacted to class/member changes in dependencies. #7326
NTaylorMullen
force-pushed
the
nimullen/7326
branch
from
a452cf6 to
096f973
Compare
|
ping |
Addresses #7326