Skip to content

Remove obsolete APIs from Razor #7326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 tasks done
mkArtakMSFT opened this issue Feb 6, 2019 · 1 comment
Closed
6 tasks done

Remove obsolete APIs from Razor #7326

mkArtakMSFT opened this issue Feb 6, 2019 · 1 comment
Assignees
@NTaylorMullen
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates breaking-change This issue / pr will introduce a breaking change, when resolved / merged. bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview3

Comments

@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Feb 6, 2019 •
edited by NTaylorMullen
Loading

See #3654 for details.

(55) src\Mvc\src\Microsoft.AspNetCore.Mvc.Razor\Compilation\CompiledViewDescriptor.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("Use Item instead. RazorViewAttribute has been superseded by RazorCompiledItem and will not be used by the runtime.")]
        public RazorViewAttribute ViewAttribute { get; set; }
#pragma warning restore CS0618 // Type or member is obsolete

(56) src\Mvc\src\Microsoft.AspNetCore.Mvc.Razor\Compilation\RazorViewAttribute.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This attribute has been superseded by RazorCompiledItem and will not be used by the runtime.")]
    [AttributeUsage(AttributeTargets.Assembly, AllowMultiple = true)]
    public class RazorViewAttribute : Attribute

(57) src\Mvc\src\Microsoft.AspNetCore.Mvc.Razor\Compilation\ViewsFeatureProvider.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is obsolete and will be removed in a future version. See " + nameof(IRazorCompiledItemProvider) + " for alternatives.")]
    public class ViewsFeatureProvider : IApplicationFeatureProvider<ViewsFeature>
    {

(58) src\Mvc\src\Microsoft.AspNetCore.Mvc.RazorPages\Infrastructure\PageArgumentBinder.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This type is obsolete and will be removed in a future version.")]
    public abstract class PageArgumentBinder
    {

(59) src\Mvc\src\Microsoft.AspNetCore.Mvc.RazorPages\Infrastructure\RazorPageAdapter.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public RazorPageAdapter(RazorPageBase page)
        {

(60) src\Mvc\src\Microsoft.AspNetCore.Mvc.RazorPages\Infrastructure\RazorPageAttribute.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
    [Obsolete("This attribute has been superseded by RazorCompiledItem and will not be used by the runtime.")]
    public class RazorPageAttribute : RazorViewAttribute
    {
@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. 1 - Ready breaking-change This issue / pr will introduce a breaking change, when resolved / merged. area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Feb 6, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview3 milestone Feb 6, 2019
NTaylorMullen pushed a commit that referenced this issue Feb 8, 2019
[MVC] Remove obsolete APIs
ccf7d64 
- Removed ViewAttribute Property
- Removed RazorViewAttribute
- Removed ViewsFeatureProvider
- Removed PageArgumentBinder and its internal implementation DefaultPageArgumentBinder.
- Removed RazorPageAttribute
- Removed corresponding test classes/methods for all the above.
- Reacted to class/member changes in dependencies.

#7326
@NTaylorMullen NTaylorMullen mentioned this issue Feb 8, 2019
Merged
NTaylorMullen pushed a commit that referenced this issue Feb 8, 2019
[MVC] Remove obsolete APIs
096f973 
- Removed ViewsFeatureProvider
- Removed PageArgumentBinder and its internal implementation DefaultPageArgumentBinder.
- Removed corresponding test classes/methods for all the above.
- Reacted to class/member changes in dependencies.

#7326
NTaylorMullen pushed a commit that referenced this issue Feb 11, 2019
[MVC] Remove obsolete APIs
dfddc4e 
- Removed ViewsFeatureProvider
- Removed PageArgumentBinder and its internal implementation DefaultPageArgumentBinder.
- Removed corresponding test classes/methods for all the above.
- Reacted to class/member changes in dependencies.

#7326
@NTaylorMullen NTaylorMullen added Done This issue has been fixed and removed 2 - Working labels Feb 11, 2019
@NTaylorMullen
Copy link

dfddc4e

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates breaking-change This issue / pr will introduce a breaking change, when resolved / merged. bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview3
Development

No branches or pull requests
2 participants
@NTaylorMullen @mkArtakMSFT