Skip to content

Remove obsolete APIs from CORS #7325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
mkArtakMSFT opened this issue Feb 6, 2019 · 0 comments
Closed
1 task done

Remove obsolete APIs from CORS #7325

mkArtakMSFT opened this issue Feb 6, 2019 · 0 comments
Assignees
@javiercn
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates breaking-change This issue / pr will introduce a breaking change, when resolved / merged. bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview3

Comments

@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Feb 6, 2019 •
edited by javiercn
Loading

See #3654 for details.

(47) src\Middleware\CORS\src\Infrastructure\CorsService.cs

Links: [master] | [release/2.2]
File a bug for this

  • I attest that I have taken appropriate action on this item
        [Obsolete("This constructor is obsolete and will be removed in a future version.")]
        public CorsService(IOptions<CorsOptions> options)
            : this(options, loggerFactory: NullLoggerFactory.Instance)
@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. 1 - Ready breaking-change This issue / pr will introduce a breaking change, when resolved / merged. area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Feb 6, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview3 milestone Feb 6, 2019
@javiercn javiercn mentioned this issue Feb 11, 2019
Merged
javiercn added a commit that referenced this issue Feb 11, 2019
@javiercn
[Antiforgery][Components][CORS] Remove obsolete APIs (#7459)
dbf746d 
#7325
#7319
#7324
@javiercn javiercn added Done This issue has been fixed and removed 1 - Ready labels Feb 11, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@javiercn javiercn

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates breaking-change This issue / pr will introduce a breaking change, when resolved / merged. bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview3
Development

No branches or pull requests
2 participants
@javiercn @mkArtakMSFT