Skip to content

Localized Microsoft.AspNet.WebPages.Data packages do not provide correct resources #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dougbu opened this issue May 10, 2022 · 1 comment
Assignees
Milestone

Comments

@dougbu
Copy link
Contributor

dougbu commented May 10, 2022

Since https://www.nuget.org/packages/Microsoft.AspNet.WebPages.Data.fr/3.1.0 and similar packages were published, the contained assembly has been named WebMatrix.WebData.resources.dll. This does not line up w/ the WebMatrix.Data.dll assembly in https://www.nuget.org/packages/Microsoft.AspNet.WebPages.Data/3.1.0. That initially just looked confusing.

The problem is much worse because the misnamed assembly is actually identical to what we ship in e.g. https://www.nuget.org/packages/Microsoft.AspNet.WebPages.WebData.fr/3.1.0. That doesn't do much good for .Data users.

Resources found in Microsoft.AspNet.WebPages.Data localized packages:
WebMatrix Data resources

Versus those found in the base assembly:
WebMatrix Data resources

Further, the namespaces don't match either (base image second):
WebMatrix Data resourceNames

@dougbu dougbu self-assigned this May 10, 2022
@dougbu dougbu added this to the 3.2.9 milestone May 10, 2022
@dougbu
Copy link
Contributor Author

dougbu commented May 27, 2022

Fixed in TFS changeset 1770739. Should be able to publish 3.2.9 / 5.2.9 containing this fix next week (Memorial Day may delay things).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants