Minimize dependencies in NetCore's _project.json
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dougbu
commented
Nov 20, 2016
dougbu
commented
- remove imports!
- bring System.Net.Http in from .NET Standard Library
- use .NET Standard version of Newtonsoft.Json
- bring other dependencies in transitively
- remove imports! - bring System.Net.Http in from .NET Standard Library - use .NET Standard version of Newtonsoft.Json - bring other dependencies in transitively
|
Hi @dougbu, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
/to @davidfowl |
|
Relates to #4 |
Eilon
suggested changes
Nov 21, 2016
| "System.ComponentModel.EventBasedAsync": "4.3.0", | ||
| "System.Diagnostics.Contracts": "4.3.0", | ||
| "System.Dynamic.Runtime": "4.3.0", | ||
| "System.Runtime.Serialization.Xml": "4.3.0-*", |
|
Should have closed this a while ago. Need to build a separate assembly instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.