Create a .NET Standard 1.1 version of System.Net.Http.Formatting.dll #42
Conversation
- bring System.Net.Http in from .NET Standard Library - use .NET Standard version of Newtonsoft.Json - bring other dependencies in transitively - create initial test project, mostly a duplicate of existing "NetCore" one nits: - write detailed information to msbuild.log - clean up trailing whitespace in a couple of test classes
|
Hi @dougbu, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| { | ||
| "supports": {}, | ||
| "dependencies": { | ||
| "NETStandard.Library": "1.6.1", |
There was a problem hiding this comment.
Not sure if this was discussed separately, but should this be LTS targeting?
There was a problem hiding this comment.
@Eilon we hadn't discussed this point. Thoughts?
dougbu
force-pushed
the
dougbu/add.net.standard
branch
from
a3d8b28 to
abee335
Compare
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
This file is for dev only, right? Can we add a comment here stating that this is for dev, and to make all real changes to the csproj?
There was a problem hiding this comment.
This is the real file for realz. The containing project is a Portable class class library targeting .NET Standard 1.1. packages.config can't be used in such projects. But the flow is almost the same: NuGet.exe reads this file, downloads packages, and writes information the build needs about resolved references into project.lock.json. Recent tooling (i.e. VS2015 *.targets files) gets that reference information and goes from there -- pretty much like any other .csproj project.
There was a problem hiding this comment.
@Eilon do you have an objection to this approach? Note that going the whole dotnet route would be comparatively old school and tie us to a specific CLI version.
There was a problem hiding this comment.
Ah, no, that's fine with me, as long as it works 😄
|
My thanks to @emgarten and @rrelyea for moving the "latest" download URL to NuGet.exe v3.5.0. Without that, the "writes information the build needs about resolved references into Thanks also to @srivatsn and @barrytang for getting me in touch w/ @emgarten and @rrelyea. |
nits: