Move tests to Newtonsoft.Json v7.0.1 #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dougbu, |
- #72 and also related to #65 - v7.0.1 is the next major version after what the product code is built against (v6.0.4) - this version corrects test failures I saw on a machine with .NET 4.7 (#72) - add binding redirects and include the app.config files in test projects - avoid new `TypeLoadException`s for Newtonsoft.Json that break numerous tests - consistently disable Copy Local (aka `%(Private)` metadata) in `src` projects - add Newtonsoft.Json references in test projects that bring it in transitively - otherwise, product code is last to mention Newtonsoft.Json assembly
dougbu
force-pushed
the
dougbu/test.failures.72
branch
from
5b521c1 to
e4c8e01
Compare
Eilon
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JObjectinstances cast todynamic#72 and also related to Update to latest tooling #65JObjectinstances cast todynamic#72)TypeLoadExceptions for Newtonsoft.Json that break numerous tests%(Private)metadata) insrcprojects