Add xUnit analyzers and take fixer suggestions (1 of 5): Common to System.Web.Cors.Test #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem.Web.Cors.Test - part of #65 - do not use `xunit.core` package in Microsoft.TestCommon - improve `TestData` behavior when tests sharing dataset properties run in parallel ExceptionResultTests.ExecuteAsync_ReturnsCorrectResponse_WhenContentNegotiationSucceedsAndIncludeErrorDetailIsTrue Manual changes: - use `Assert.IsAssignableFrom<T>(...)`, `Assert.IsType<T>(...)` and `Assert.Single(...)` return values - work around xUnit1013, Public method should be marked as test - move duplicated `[Theory]` and `[TestDataSet(...)]` attributes down to `abstract` methods - add suppression due to xnuit/xunit#1466 - work around xUnit1026, `[Theory]` method doesn't use all parameters - add new data sets or `GC.KeepAlive(...)` - reset `OAuthWebSecurity.OAuthDataProvider` after use in two tests
|
@dougbu, |
Eilon
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xunit.corepackage in Microsoft.TestCommonTestDatabehavior when tests sharing dataset properties run in parallelManual changes:
Assert.IsAssignableFrom<T>(...),Assert.IsType<T>(...)andAssert.Single(...)return values[Theory]and[TestDataSet(...)]attributes down toabstractmethods[Theory]method doesn't use all parametersGC.KeepAlive(...)OAuthWebSecurity.OAuthDataProviderafter use in two tests