Skip to content

set WaitForDataBeforeAllocatingBuffer to false for PlatformBenchmarks #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2020
Merged

set WaitForDataBeforeAllocatingBuffer to false for PlatformBenchmarks #1469

merged 2 commits into from
Apr 3, 2020

Conversation

adamsitnik
Copy link
Contributor

It's a follow up of dotnet/aspnetcore#19396

It gives +15k RPS for JSON and something around +30k RPS for Plaintext at a cost of 2MB of increased working set (for 256 connections)

/cc @tmds @sebastienros

@sebastienros sebastienros merged commit 342314f into aspnet:master Apr 3, 2020
@adamsitnik adamsitnik deleted the dontWaitForData branch April 3, 2020 16:00
@davidfowl davidfowl mentioned this pull request Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamsitnik @sebastienros