Skip to content

Reapply "Add Cobalt Cloud machine Azure CI profile and runs. (#2088)" (#2089) #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

LoopedBard3
Copy link
Contributor

Reapply "Add Cobalt Cloud machine Azure CI profile and runs. (#2088)" (#2089)

This reverts commit ed6ac8c.

The service bus connection should be working properly now so remerging this. (Docker logs showed message pulled from service bus instead of connection error).

Working test run here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2705137&view=results, shows that the service bus connection is now working. (The test run no longer has the profile available, so it is failing, but it shows that the service bus connection is working).

@LoopedBard3 LoopedBard3 self-assigned this May 9, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reintroduces the Cobalt Cloud machine Azure CI profile to restore proper service bus connectivity. Key changes include:

  • Adding new Cobalt Cloud Linux jobs to both the benchmarks matrix and CI pipeline files.
  • Updating job dependencies to incorporate the new Cobalt Cloud jobs.
  • Defining new Azure profile configurations for cobalt-cloud-lin and cobalt-cloud-lin-relay.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
build/benchmarks.matrix.azure.yml Added Cobalt Cloud queue and job groups for CI testing
build/benchmarks-ci-azure.yml Introduced new Cobalt Cloud jobs and updated dependencies in the pipeline
build/azure.profile.yml Added new profile definitions for cobalt-cloud-lin and cobalt-cloud-lin-relay
Comments suppressed due to low confidence (1)

build/benchmarks-ci-azure.yml:72

  • [nitpick] Consider aligning the naming convention between 'cobaltcloud' used for serviceBusQueueName and 'cobalt-cloud-lin' for the profile to improve clarity and consistency across the configuration.
serviceBusQueueName: cobaltcloud

- https://aspnetperf.servicebus.windows.net/azurearm64client
aliases:
- warmup
- secondary

Copy link
Preview

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding brief documentation or comments to clarify the purpose and configuration details for the new cobalt cloud profiles, which can help improve maintainability.

Suggested change
# Profile for the Cobalt Cloud Linux environment.
# This profile is used for deployments in the Cobalt Cloud infrastructure
# with direct HTTP endpoints for database, application, and load services.

Copilot uses AI. Check for mistakes.

@LoopedBard3 LoopedBard3 merged commit 2b8c6a4 into aspnet:main May 9, 2025
2 checks passed
@LoopedBard3 LoopedBard3 deleted the RevertRevert branch May 9, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants